Bug 498828 – x11-misc/sddm patches

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Gino McCarty 2014-01-21 20:14:14 UTC]

There is allot going on in here, so here is a summary

*Replace Xsession with modified version from lxdm
Why: packaged Xsession (from kde) runs /etc/xinitrc.d twice..
https://github.com/sddm/sddm/issues/126

*Patch for /etc/xinit.d/xdm
This one is a bit tricky but this file will need to get modified for sddm to boot properly.. otherwise xdm will just hang forever on boot when it calls sddm using the last * switch case. This is bad and will jam up openrc..
I suppose the other option is to modify sddm code to fall to background on start


*uPower dependency should be optional (filed another ticket earlier for this)
but patch changes appear in here also..
Basically sddm does not require this, and some weird users (like me) don't use it.



Reproducible: Always

[Comment 1 Gino McCarty 2014-01-21 20:15:01 UTC]

Created attachment 368374 [details]
new sddm-9999.ebuild file

[Comment 2 Gino McCarty 2014-01-21 20:15:32 UTC]

Created attachment 368376 [details]
modified lxdm Xsession file

[Comment 3 Gino McCarty 2014-01-21 20:16:12 UTC]

Created attachment 368378 [details, diff]
/etc/xinit.d/xdm patch

I do understand that this is probably a very bad thing to do.. but not sure how else this would get done.

[Comment 4 Gino McCarty 2014-01-22 02:03:35 UTC]

Created attachment 368414 [details]
sddm-9999.ebuild v2

Sorry the last file has some issues with replacing Xsession file

[Comment 5 Ben de Groot (RETIRED) 2014-01-22 10:54:36 UTC]

(In reply to Bombino from comment #4)
> Created attachment 368414 [details]
> sddm-9999.ebuild v2
> 
> Sorry the last file has some issues with replacing Xsession file

Thanks for helping out to get sddm to work on Gentoo.

I do see a few problems with your ebuild though:
1) src_prepare has an added comment, but no command to patch mentioned file
2) the attached Xsession file still references lxde and lxdm, which is not what we want here
3) we shouldn't use pkg_postinst for patching stuff (src_prepare is the right place for that) or installing files (src_install is the right place for that)

[Comment 6 Ben de Groot (RETIRED) 2014-01-22 10:57:44 UTC]

(In reply to Bombino from comment #3)
> Created attachment 368378 [details, diff] [details, diff]
> /etc/xinit.d/xdm patch
> 
> I do understand that this is probably a very bad thing to do.. but not sure
> how else this would get done.

we should open a new bug to request this patch to be applied to x11-base/xorg-server

[Comment 7 Gino McCarty 2014-01-22 23:29:49 UTC]

(In reply to Ben de Groot from comment #6)
> (In reply to Bombino from comment #3)
> > Created attachment 368378 [details, diff] [details, diff] [details, diff]
> > /etc/xinit.d/xdm patch
> > 
> > I do understand that this is probably a very bad thing to do.. but not sure
> > how else this would get done.
> 
> we should open a new bug to request this patch to be applied to
> x11-base/xorg-server

Done:
https://bugs.gentoo.org/show_bug.cgi?id=498972

[Comment 8 Gino McCarty 2014-01-22 23:46:06 UTC]

Created attachment 368492 [details, diff]
sddm-999.ebuild v3

[Comment 9 Gino McCarty 2014-01-22 23:46:55 UTC]

Created attachment 368494 [details]
New Xsession file

[Comment 10 Gino McCarty 2014-01-22 23:47:21 UTC]

(In reply to Ben de Groot from comment #5)
> (In reply to Bombino from comment #4)
> > Created attachment 368414 [details]
> > sddm-9999.ebuild v2
> > 
> > Sorry the last file has some issues with replacing Xsession file
> 
> Thanks for helping out to get sddm to work on Gentoo.
> 
> I do see a few problems with your ebuild though:
> 1) src_prepare has an added comment, but no command to patch mentioned file
> 2) the attached Xsession file still references lxde and lxdm, which is not
> what we want here
> 3) we shouldn't use pkg_postinst for patching stuff (src_prepare is the
> right place for that) or installing files (src_install is the right place
> for that)

Ok made those changes, this new Xsession file should get tested but aside from that, ready to go.

[Comment 11 Gino McCarty 2014-01-23 00:46:31 UTC]

Created attachment 368496 [details]
v3

[Comment 12 Andreas Sturmlechner 2014-01-27 01:42:51 UTC]

cool, this works!

now if we could also get shutdown/reboot to work with openrc...

[Comment 13 Gino McCarty 2014-01-27 03:05:40 UTC]

(In reply to Andreas Sturmlechner from comment #12)
> cool, this works!
> 
> now if we could also get shutdown/reboot to work with openrc...

On an unrelated note, my sddm reboot and shutdown work fine, but logout of any session will freeze everything up...
perhaps separate bug reports are in order..

[Comment 14 Andreas Sturmlechner 2014-01-27 21:02:27 UTC]

(In reply to Bombino from comment #13)
> On an unrelated note, my sddm reboot and shutdown work fine
Maybe we should compare various system configs...

> but logout of
> any session will freeze everything up...
> perhaps separate bug reports are in order..
Confirmed for sddm-9999, but 0.1.0 including your Xsession file works just fine.

[Comment 15 Gino McCarty 2014-02-12 21:50:22 UTC]

As per conversation at https://bugs.gentoo.org/show_bug.cgi?id=498404
I have revised the build for 9999 again.. here if you have systemd upower is no longer required..

[Comment 16 Gino McCarty 2014-02-12 21:51:13 UTC]

Created attachment 370252 [details]
sddm-9999.ebuild - Newest Ebuild Revision (v4)

[Comment 17 Andreas Sturmlechner 2014-05-13 19:15:24 UTC]

Created attachment 376848 [details, diff]
diff against latest sddm-9999 rev from qt overlay

sddm[qt5] requires dev-qt/linguist-tools:5 to configure.

[Comment 18 Jauhien Piatlicki (RETIRED) 2014-05-24 19:42:35 UTC]

Please, test x11-misc/sddm from the tree. For me it works without any further modifications. 9999 version works for me also as it is now.