Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 498820 - bash-completion-r1.eclass: uses pkg-config without depending on it
Summary: bash-completion-r1.eclass: uses pkg-config without depending on it
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: eselect (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
: 498822 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-21 17:57 UTC by ViliusSutkus89
Modified: 2014-01-22 20:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eselect-1.4.ebuild.patch (file_498820.txt,293 bytes, patch)
2014-01-21 17:57 UTC, ViliusSutkus89
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ViliusSutkus89 2014-01-21 17:57:55 UTC
Created attachment 368364 [details, diff]
eselect-1.4.ebuild.patch

Steps to reproduce:
1. emerge --depclean --with-bdeps=n
2. emerge --oneshot app-admin/eselect

Result:
>>> Messages generated by process 31633 on 2014-01-21 17:15:11 UTC for package app-admin/eselect-1.4:

QA: install
QA Notice: command not found:

	/var/tmp/portage/app-admin/eselect-1.4/temp/environment: line 184: pkg-config: command not found

Attaching proposed PATCH.
Comment 1 Ulrich Müller gentoo-dev 2014-01-22 07:12:00 UTC
Please attach build.log and emerge --info output.
Comment 2 Ulrich Müller gentoo-dev 2014-01-22 07:30:19 UTC
> Please attach build.log and emerge --info output.

... and the temp/environment file.


@mgorny: My guess is that pkg-config gets called from _bash-completion-r1_get_bashdir(). Maybe bash-completion-r1.eclass should have virtual/pkgconfig in DEPEND?
Comment 3 ViliusSutkus89 2014-01-22 10:16:58 UTC
eselect-1.4/temp/environment:

_bash-completion-r1_get_bashdir () 
{ 
    debug-print-function ${FUNCNAME} "${@}";
line 184:    if $(tc-getPKG_CONFIG) --exists bash-completion; then
        local path="$($(tc-getPKG_CONFIG) --variable=$1 bash-completion)";
        echo "${path#${EPREFIX}}";
    else
        echo $2;
    fi
}
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-01-22 12:10:56 UTC
  15 Jul 2013; Samuli Suominen <ssuominen@gentoo.org>
  bash-completion-r1.eclass:
  Support pkg-config and the new upstream completions directory structure wrt
  #472938 and introduce new get_bashhelpersdir function to obtain the
  helpersdir="" value.

As far as I'm concerned, we should just add the DEPEND to the eclass but I think this would cause a major uproar and has some circular dependency potential.
Comment 5 Tim Harder gentoo-dev 2014-01-22 19:29:38 UTC
*** Bug 498822 has been marked as a duplicate of this bug. ***
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2014-01-22 20:54:10 UTC
The QA warning is bogus, the .eclass handles the situation where pkg-config is not installed already properly

However I've added suppression (redirect to stderr) to get rid of the bogus QA warning:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/bash-completion-r1.eclass?r1=1.11&r2=1.12