Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 498062 - sys-kernel/dracut: binary file in gentoo-x86
Summary: sys-kernel/dracut: binary file in gentoo-x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Amadeusz Żołnowski (RETIRED)
URL: http://qa-reports.gentoo.org/output/f...
Whiteboard:
Keywords:
Depends on:
Blocks: binaries-in-git
  Show dependency tree
 
Reported: 2014-01-14 12:01 UTC by Ulrich Müller
Modified: 2014-01-19 11:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2014-01-14 12:01:39 UTC
As reported, see URL: 
sys-kernel/dracut/files/034-0010-module-setup.sh-add-comments.patch.bz2

Binary files should be distributed via distfiles. CVS (and in the future, git) doesn't handle binary files well.

Also the total size of the files dir is in the top ten of all packages:
http://qa-reports.gentoo.org/output/filesdir-usage.txt
Comment 1 Amadeusz Żołnowski (RETIRED) gentoo-dev 2014-01-14 14:40:17 UTC
I don't know anything good about CVS, so I believe you. :-) But if it comes to Git I would object. Patches are usually things which are not modified, but are removed/added, so it actually doesn't matter much if it is text or binary. Anyway could you justify your accusation against Git?

I'll be removing old ebuilds soon, so the size will decrease. I will think of moving the bz2 file outside portdir.
Comment 2 Ulrich Müller gentoo-dev 2014-01-14 15:57:32 UTC
(In reply to Amadeusz Żołnowski from comment #1)

There is a policy on this, so there is no need for us to discuss here:

<http://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-in-the-tree?>
# Things that do not belong in the tree:
# * Large patches
# * Non-text files

<http://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html>
# Larger patches should be mirrored, preferrable on the Gentoo Infrastructure.
# When mirroring patches, choosing a name that will not cause conflicts is
# important — the ${P} prefix is highly recommended here. Mirrored patches are
# often compressed with bzip2. Remember to list these patches in SRC_URI.
#
# Note: Patches included in ${FILESDIR} should never be compressed.
#
# If a package requires many patches, even if they are individually small, it
# is often best to create a patch tarball to avoid cluttering up the tree too
# much.


> I'll be removing old ebuilds soon, so the size will decrease. I will think
> of moving the bz2 file outside portdir.

Thanks.