Bug 497966 – kernel-2.eclass is calling python2 without using python-*.eclass

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Justin Lecher (RETIRED) 2014-01-13 07:29:12 UTC]

 $ grep python kernel-2.eclass -5
				DEBLOB_CHECK_URI="mirror://gentoo/${DEBLOB_CHECK_A}"
			fi
			DEBLOB_URI="${DEBLOB_HOMEPAGE}/${DEBLOB_URI_PATH}/${DEBLOB_A}"
			HOMEPAGE="${HOMEPAGE} ${DEBLOB_HOMEPAGE}"

			DEPEND+=" deblob? ( =dev-lang/python-2* )"
			KERNEL_URI="${KERNEL_URI}
				deblob? (
					${DEBLOB_URI}
					${DEBLOB_CHECK_URI}
				)"
--
	cd "${S}"
	[[ ${ETYPE} == headers ]] && compile_headers

	if [[ $K_DEBLOB_AVAILABLE == 1 ]] && use deblob ; then
		echo ">>> Running deblob script ..."
		EPYTHON="python2" sh "${T}/${DEBLOB_A}" --force || die "Deblob script failed to run!!!"
	fi
}

# if you leave it to the default src_test, it will run make to
# find whether test/check targets are present; since "make test"

[Comment 1 Mike Pagano 2014-01-17 18:14:31 UTC]

+  17 Jan 2014; Michael Pagano <[e-mail]> kernel-2.eclass:
+  Fix kernel-2.eclass to use python.eclass for it's python needs. (deblob
+  script). See bug #497966
+

[Comment 2 Mike Gilbert 2014-01-17 19:18:52 UTC]

I would recommend migrating to python-any-r1.eclass; python.eclass is being phased out.

[Comment 3 Justin Lecher (RETIRED) 2014-01-17 19:52:46 UTC]

Mike is right. please migrate to python-any.r1.eclass instead of using the old one.

[Comment 4 Mike Gilbert 2014-01-17 20:18:36 UTC]

Also, the current usage of python.eclass is a bit broken. PYTHON_DEPEND must be set before inherit, and there is no call to python_set_active_version.

If you would like me to work on a patch to improve this, I would be happy to do so.

[Comment 5 Mike Pagano 2014-01-18 01:13:41 UTC]

(In reply to Mike Gilbert from comment #4)
> Also, the current usage of python.eclass is a bit broken. PYTHON_DEPEND must
> be set before inherit, and there is no call to python_set_active_version.
> 
> If you would like me to work on a patch to improve this, I would be happy to
> do so.


That would be great. Thanks.

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2014-01-18 01:17:32 UTC]

Created attachment 368066 [details, diff]
deblob-check-3.12-python-3.patch

This patch makes deblob-check compatible with Python 3.

This patch applies cleanly for deblob-check-3.12. This patch applies with some offsets to other versions. I verified versions from 3.0 to 3.12.

[Comment 7 Mike Gilbert 2014-01-18 03:22:15 UTC]

Created attachment 368068 [details, diff]
Convert to python-any-r1

Here's a patch to convert to python-any-r1.

If you also apply Arfrever's patch, you could add python{3_2,3_3} to PYTHON_COMPAT.

[Comment 8 Mike Gilbert 2014-01-18 03:24:18 UTC]

Created attachment 368070 [details, diff]
Corrected python-any-r1 patch

[Comment 9 Mike Gilbert 2014-01-18 14:54:35 UTC]

I went ahead and committed my patch to kernel-2.eclass.

What would be the best way to get Arfrever's python3-compatibility patch applied? Is there an upstream you/we can appeal to?

[Comment 10 Mike Pagano 2014-01-18 18:54:49 UTC]

(In reply to Arfrever Frehtes Taifersar Arahesis from comment #6)
> Created attachment 368066 [details, diff] [details, diff]
> deblob-check-3.12-python-3.patch
> 
> This patch makes deblob-check compatible with Python 3.
> 
> This patch applies cleanly for deblob-check-3.12. This patch applies with
> some offsets to other versions. I verified versions from 3.0 to 3.12.

Thanks. Feel free to submit upstream.

[Comment 11 Mike Pagano 2014-01-18 18:55:53 UTC]

libre-linux:

http://www.fsfla.org/ikiwiki/selibre/linux-libre/index.en.html

[Comment 12 Justin Lecher (RETIRED) 2016-01-25 08:20:25 UTC]

seems to be fixed.