Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497944 - sys-apps/systemd - check for kernel config option CONFIG_DEVPTS_MULTIPLE_INSTANCES
Summary: sys-apps/systemd - check for kernel config option CONFIG_DEVPTS_MULTIPLE_INST...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-12 21:54 UTC by Alexander Tsoy
Modified: 2014-05-09 00:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2014-01-12 21:54:52 UTC
systemd-nspawn tries to mount /dev/pts inside a container with options "newinstance,ptmxmode=0666", which are valid only if kernel is compiled with CONFIG_DEVPTS_MULTIPLE_INSTANCES.

From the journal:
systemd-machined[25079]: New machine build.
systemd[1]: Starting Container build.
systemd[1]: Started Container build.
kernel: devpts: called with bogus options
Comment 1 Mike Gilbert gentoo-dev 2014-01-12 22:43:53 UTC
Yeah, I ran into that myself. Given that systemd-nspawn is a developer-oriented tool, I am not sure that a kernel check in the ebuild is appropriate.

systemd-nspawn also uses several namespace features:

CONFIG_UTS_NS
CONFIG_IPC_NS
CONFIG_PID_NS
CONFIG_NET_NS
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-01-12 22:46:24 UTC
Can't systemd units have the same issues, assuming they use some of the more advanced options systemd gives them?
Comment 3 Mike Gilbert gentoo-dev 2014-01-12 22:55:13 UTC
I don't think there are any unit options requiring CONFIG_DEVPTS_MULTIPLE_INSTANCES.

A unit with PrivateNetwork=true would require CONFIG_NET_NS.

Not sure on the others.
Comment 4 Alexander Tsoy 2014-01-13 16:33:54 UTC
(In reply to Mike Gilbert from comment #3)
> I don't think there are any unit options requiring
> CONFIG_DEVPTS_MULTIPLE_INSTANCES.

Yes. Seems it is only needed for systemd-nspawn
Comment 5 Alexander Tsoy 2014-01-13 21:50:00 UTC
(In reply to Mike Gilbert from comment #1)
> Yeah, I ran into that myself. Given that systemd-nspawn is a
> developer-oriented tool, I am not sure that a kernel check in the ebuild is
> appropriate.

OK, agreed. Too many checks for a small tool used by a few people.

> 
> systemd-nspawn also uses several namespace features:
> 
> CONFIG_UTS_NS
> CONFIG_IPC_NS
> CONFIG_PID_NS
> CONFIG_NET_NS

And it's probably incompatible with several GRKERNSEC_CHROOT_* options (taken fom lxc ebuild):

~!GRKERNSEC_CHROOT_MOUNT
~!GRKERNSEC_CHROOT_DOUBLE
~!GRKERNSEC_CHROOT_PIVOT
~!GRKERNSEC_CHROOT_CHMOD
~!GRKERNSEC_CHROOT_CAPS
Comment 6 Leho Kraav (:macmaN @lkraav) 2014-05-09 00:16:53 UTC
This would've saved me loads of time :/
Comment 7 Leho Kraav (:macmaN @lkraav) 2014-05-09 00:19:27 UTC
Something like einfo at least would be nice.
Comment 8 Mike Gilbert gentoo-dev 2014-05-09 00:55:21 UTC
Sorry, but I just don't think it makes sense to warn everybody about something that only developers would care about.