Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497808 - net-misc/freerdp-1.1.0_beta1_p20130710 - build fix for sys-libs/uclibc
Summary: net-misc/freerdp-1.1.0_beta1_p20130710 - build fix for sys-libs/uclibc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-01-11 17:02 UTC by René Rhéaume
Modified: 2014-08-20 01:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add for uclibc support (freerdp-1.1.0_beta1_p20130710-uclibc.patch,1.58 KB, patch)
2014-01-11 17:03 UTC, René Rhéaume
Details | Diff
New patch to add uclibc support (freerdp-1.1.0_beta1_p20130710-uclibc-r1.patch,1.71 KB, patch)
2014-08-05 11:08 UTC, René Rhéaume
Details | Diff
freerdp-1.1.0_beta1_p20130710-uclibc-r2.patch (freerdp-1.1.0_beta1_p20130710-uclibc-r2.patch,1.79 KB, patch)
2014-08-20 00:51 UTC, René Rhéaume
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René Rhéaume 2014-01-11 17:02:01 UTC
freerdp cannot be built as is on uclibc systems because three functions are missing on uclibc : futimes (a BSD extension), eventfd_read and eventfd_write. 

For the former, futimes can be replaced by utimes as on Android and the 2 others, they can be pasted from bionic source (as both bionic and freerdp are both under the Apache 2.0 license).

Reproducible: Always

Steps to Reproduce:
1. Install Lilblue
2. emerge -1 freerdp
Actual Results:  
emake failed

Expected Results:  
freerdp installed on system
Comment 1 René Rhéaume 2014-01-11 17:03:04 UTC
Created attachment 367648 [details, diff]
Patch to add for uclibc support
Comment 2 Alex Xu (Hello71) 2014-01-12 01:49:26 UTC
Have you tried sending this patch upstream?
Comment 3 René Rhéaume 2014-01-12 16:52:25 UTC
Filed an issue upstream

https://github.com/FreeRDP/FreeRDP/issues/1660
Comment 4 SpanKY gentoo-dev 2014-08-03 14:32:18 UTC
it should stop using futimes and switch to futimens as the latter is in POSIX and glibc/uClibc already support it

the latter two probably need to be fixed in uClibc itself since we provide sys/eventfd.h and eventfd()
Comment 5 René Rhéaume 2014-08-05 11:08:34 UTC
Created attachment 382318 [details, diff]
New patch to add uclibc support
Comment 6 Mike Gilbert gentoo-dev 2014-08-05 14:36:52 UTC
Does the same problem occur when building against git master? You can use freerdp-9999 to check.

If it does, please rebase your patch against the current git master and submit a pull request upstream.

https://github.com/FreeRDP/FreeRDP

Once I know this has been fixed upstream, I would be happy to apply your patch to the current snapshot in the portage tree.
Comment 7 Mike Gilbert gentoo-dev 2014-08-05 14:38:34 UTC
Oh, now I see comment 3.

Get this fixed upstream first, then we can get it fixed here.
Comment 8 René Rhéaume 2014-08-07 03:33:17 UTC
Pull request for upstream head

https://github.com/FreeRDP/FreeRDP/pull/2024
Comment 9 René Rhéaume 2014-08-20 00:51:59 UTC
Created attachment 383160 [details, diff]
freerdp-1.1.0_beta1_p20130710-uclibc-r2.patch

New revision of the source code patch based on the pull request merged upstream, the change being keeping Mac OS X compatibility
Comment 10 Mike Gilbert gentoo-dev 2014-08-20 01:20:44 UTC
+  20 Aug 2014; Mike Gilbert <floppym@gentoo.org>
+  +files/freerdp-1.1.0_beta1_p20130710-uclibc.patch,
+  freerdp-1.1.0_beta1_p20130710-r2.ebuild:
+  Add build fix for uclibc, bug 497808. Thanks to René Rhéaume for the patch.