Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497042 - netsurf.eclass: remove base.eclass inherit
Summary: netsurf.eclass: remove base.eclass inherit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 497022
  Show dependency tree
 
Reported: 2014-01-04 22:25 UTC by Chris Reffett (RETIRED)
Modified: 2014-12-24 09:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Reffett (RETIRED) gentoo-dev Security 2014-01-04 22:25:58 UTC
Your eclass inherits base.eclass. For several reasons, we at the QA team would like to remove base, and so we ask that you remove the inherit. See bug 497022 for notes on transitioning your eclass away from the base inherit and checking for problems that could crop up.
Comment 1 Michael Weber (RETIRED) gentoo-dev 2014-11-15 14:32:01 UTC
@qa: can you please sign off these changes to netsurf.eclass?

Index: netsurf.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/netsurf.eclass,v
retrieving revision 1.1
diff -u -B -r1.1 netsurf.eclass
--- netsurf.eclass      23 Jun 2013 16:36:49 -0000      1.1
+++ netsurf.eclass      15 Nov 2014 14:30:30 -0000
@@ -17,7 +17,7 @@
        *) ;;
 esac
 
-inherit base toolchain-funcs multilib-minimal
+inherit eutils toolchain-funcs multilib-minimal
 
 EXPORT_FUNCTIONS src_prepare src_configure src_compile src_install
 
@@ -56,10 +56,12 @@
 
 # @FUNCTION: netsurf_src_prepare
 # @DESCRIPTION:
-# Run base_src_prepare for PATCHES support and multilib_copy_sources for 
-# in-source build.
+# Apply and PATCHES and multilib_copy_sources for in-source build.
 netsurf_src_prepare() {
-       base_src_prepare
+       [[ ${PATCHES[@]} ]] && epatch "${PATCHES[@]}"
+       debug-print "$FUNCNAME: applying user patches"
+       epatch_user
+
        multilib_copy_sources
 }
Comment 2 Michael Weber (RETIRED) gentoo-dev 2014-12-24 09:58:09 UTC
+  24 Dec 2014; Michael Weber <xmw@gentoo.org> netsurf.eclass:
+  remove base.eclass inherit
+