Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496964 - sys-apps/acl - add multilib support
Summary: sys-apps/acl - add multilib support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gx86-multilib
  Show dependency tree
 
Reported: 2014-01-04 12:57 UTC by Michael Mair-Keimberger (iamnr3)
Modified: 2014-05-02 10:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
acl-2.2.52.ebuild.patch (acl-2.2.52.ebuild.patch,1.61 KB, patch)
2014-01-04 12:57 UTC, Michael Mair-Keimberger (iamnr3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mair-Keimberger (iamnr3) 2014-01-04 12:57:27 UTC
Created attachment 366960 [details, diff]
acl-2.2.52.ebuild.patch

I've created a multilib patch for sys-apps/acl (with help from mgorny). Please review!
Comment 1 SpanKY gentoo-dev 2014-01-04 14:55:45 UTC
Comment on attachment 366960 [details, diff]
acl-2.2.52.ebuild.patch

>+	# same as https://savannah.nongnu.org/bugs/index.php?39736 
>+	multilib_copy_sources

doesn't seem like it'd be hard to fix.  let's at least try first.

the rest looks fine
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-01-04 15:18:45 UTC
(In reply to SpanKY from comment #1)
> Comment on attachment 366960 [details, diff] [details, diff]
> acl-2.2.52.ebuild.patch
> 
> >+	# same as https://savannah.nongnu.org/bugs/index.php?39736 
> >+	multilib_copy_sources
> 
> doesn't seem like it'd be hard to fix.  let's at least try first.

Well, aballier tried with sys-apps/attr and failed. The problem is that the package uses a completely custom build system on top of autoconf, and it has practically no awareness of build-dir/source-dir. Makefiles are bundled and only a single 'makedefs' file is generated via configure, and configure.ac is not included in the tarball.

Long story short, it sucks pretty hard and implementing out-of-source builds the common autotools way would require a lot of changes, including design changes.
Comment 3 SpanKY gentoo-dev 2014-01-08 19:33:50 UTC
(In reply to Michał Górny from comment #2)

i've sent upstream attr patches to gut their build system.  assuming it goes well, i'll make the same change to acl.
Comment 4 SpanKY gentoo-dev 2014-01-19 03:55:01 UTC
(In reply to SpanKY from comment #3)

they've merged my changes for both acl & attr now.  so it should be a standard autotools build for both (which means support clean out of tree builds).
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-05-02 10:18:55 UTC
Thanks for the effort, Mike. However, since upstream didn't do a release yet and the patch is quite large, I have committed the source-duplicating version for now.

+*acl-2.2.52-r1 (02 May 2014)
+
+  02 May 2014; Michał Górny <mgorny@gentoo.org> +acl-2.2.52-r1.ebuild:
+  Introduce multilib support, bug #496964.

p.masked as usual, open to suggestions for some time.