Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496720 - net-analyzer/metasploit post-install section must notify user to run env-update
Summary: net-analyzer/metasploit post-install section must notify user to run env-update
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 03:04 UTC by Anton Bolshakov
Modified: 2014-04-17 18:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2014-01-02 03:04:06 UTC
metasploit installs a new env file into:
/etc/env.d/91metasploit

the software won't run after the initial install because user must update env variables either by running env-update or relogining.

Please add that note to the post-install message.
Comment 1 Anton Bolshakov 2014-01-02 03:16:29 UTC
also, please swap the following two lines:

        elog "emerge --config postgresql-server"
        elog "/etc/init.d/postgresql-<version> start"


The database must be up before running config.
Comment 2 Rick Farina (Zero_Chaos) gentoo-dev 2014-01-02 04:22:14 UTC
(In reply to Anton Bolshakov from comment #1)
> also, please swap the following two lines:
> 
>         elog "emerge --config postgresql-server"
>         elog "/etc/init.d/postgresql-<version> start"
> 
> 
> The database must be up before running config.

the postinst message for postgresql directly contradicts that. Also, my scripts for doing it contradict that. in a word, no.
Comment 3 Anton Bolshakov 2014-01-02 04:27:10 UTC
ok, double check it. Because it contradicts with:

pkg_config() {
        einfo "If the following fails, it is likely because you forgot to start/config postgresql first"
Comment 4 Rick Farina (Zero_Chaos) gentoo-dev 2014-01-02 04:43:02 UTC
(In reply to Anton Bolshakov from comment #3)
> ok, double check it. Because it contradicts with:
> 
> pkg_config() {
>         einfo "If the following fails, it is likely because you forgot to
> start/config postgresql first"

no, it doesn't.

Metasploit's pkg_config requires postgres to be started.

postgres requires it's pkg_config to be run before it can be started.

There are no contradictions in the metasploit postinst or config output.  I am happy to accept suggestions for improvement, but as it stands now it is correct.
Comment 5 Rick Farina (Zero_Chaos) gentoo-dev 2014-01-02 04:43:02 UTC
(In reply to Anton Bolshakov from comment #3)
> ok, double check it. Because it contradicts with:
> 
> pkg_config() {
>         einfo "If the following fails, it is likely because you forgot to
> start/config postgresql first"

no, it doesn't.

Metasploit's pkg_config requires postgres to be started.

postgres requires it's pkg_config to be run before it can be started.

There are no contradictions in the metasploit postinst or config output.  I am happy to accept suggestions for improvement, but as it stands now it is correct.
Comment 6 Rick Farina (Zero_Chaos) gentoo-dev 2014-04-17 18:14:27 UTC
+  17 Apr 2014; Rick Farina <zerochaos@gentoo.org> metasploit-4.9.2-r1.ebuild,
+  metasploit-9999.ebuild:
+  add elog command to warn user to update their env before running, bug #496720