Created attachment 366562 [details] emerge --info I use sv as localisation. When compiling q4wine it seartch for the file q4wine_OFF.qm. As sv is not included as localisation of the q4wine it defaults to off. And that file do not exist. Better to default to en. during config: -- Process LINGUAS variable -- -- Add translation for OFF: OFF.ts Error: Scanning dependencies of target translations_build make[2]: Leaving directory '/var/tmp/portage/app-emulation/q4wine-1.1_p2-r1/work/q4wine-1.1_p2_build' make -f src/i18n/CMakeFiles/translations_build.dir/build.make src/i18n/CMakeFiles/translations_build.dir/build make[2]: Entering directory '/var/tmp/portage/app-emulation/q4wine-1.1_p2-r1/work/q4wine-1.1_p2_build' cd /var/tmp/portage/app-emulation/q4wine-1.1_p2-r1/work/q4wine-1.1-r2/src/i18n && /usr/bin/lrelease q4wine_OFF.ts -qm /var/tmp/portage/app-emulation/q4wine-1.1_p2-r1/work/q4wine-1.1_p2_build/src/i18n/q4wine_OFF.qm lrelease error: Cannot open q4wine_OFF.ts: No such file or directory src/i18n/CMakeFiles/translations_build.dir/build.make:55: recipe for target 'translations_build' failed make[2]: *** [translations_build] Error 1
Please attach the entire build log to this bug report.
Created attachment 366588 [details] Build log of q4wine
Did 1.1_p2 used to work? I wonder if this is a regression in -r1 due to the ebuild clean up.
(In reply to Markos Chandras from comment #3) > Did 1.1_p2 used to work? I wonder if this is a regression in -r1 due to the > ebuild clean up. Yes 1.1_p2 emerge OK. Snippet from my build log: 1387328110: >>> emerge (2 of 2) app-emulation/q4wine-1.1_p2 to / 1387328110: === (2 of 2) Cleaning (app-emulation/q4wine-1.1_p2::/usr/portage/app-emulation/q4wine/q4wine-1.1_p2.ebuild) 1387328110: === (2 of 2) Compiling/Merging (app-emulation/q4wine-1.1_p2::/usr/portage/app-emulation/q4wine/q4wine-1.1_p2.ebuild) 1387328327: === (2 of 2) Merging (app-emulation/q4wine-1.1_p2::/usr/portage/app-emulation/q4wine/q4wine-1.1_p2.ebuild) 1387328333: >>> AUTOCLEAN: app-emulation/q4wine:0 1387328333: === Unmerging... (app-emulation/q4wine-1.1_p1) 1387328340: >>> unmerge success: app-emulation/q4wine-1.1_p1 1387328347: === (2 of 2) Post-Build Cleaning (app-emulation/q4wine-1.1_p2::/usr/portage/app-emulation/q4wine/q4wine-1.1_p2.ebuild) 1387328347: ::: completed emerge (2 of 2) app-emulation/q4wine-1.1_p2 to / 1387328347: *** Finished. Cleaning up... 1387328353: *** exiting successfully. 1387328369: *** terminating.
Sorry from emerge.log.
from src/CMakeLists.txt: SET ( LINGUAS en_us ru_ru uk_ua pt_br es_es it_it cs_cz he_il pl_pl de_de fa_ir af_za) There isn't any "sv" lingua, therefore it should be removed from the ebuild too. We should also add PLOCALE_BACKUP="en"
(In reply to Davide Pesavento from comment #6) > from src/CMakeLists.txt: > SET ( LINGUAS en_us ru_ru uk_ua pt_br es_es it_it cs_cz he_il pl_pl > de_de fa_ir af_za) > > There isn't any "sv" lingua, therefore it should be removed from the ebuild > too. > > We should also add PLOCALE_BACKUP="en" I am confused. I can't see the "sv" locale in PLOCALES or any other reference of "sv" in the ebuild.
Just add PLOCALE_BACKUP then.
(In reply to Davide Pesavento from comment #8) > Just add PLOCALE_BACKUP then. PLOCALE_BACKUP=en or PLOCALE_BACKUP=en_us does not fix the problem
Also this line in the build looks weird -- Process LINGUAS variable -- -- Add translation for OFF: OFF.ts
(In reply to Markos Chandras from comment #10) > Also this line in the build looks weird > > -- Process LINGUAS variable -- > > -- Add translation for OFF: OFF.ts Yes, this is why the build fails later on.
I think there's a bug in l10n.eclass (CC'ing maintainer). Let's assume that PLOCALES="en it", PLOCALE_BACKUP="en", and no LINGUAS are enabled. The following happens: `l10n_get_locales` returns 'en' `l10n_get_locales disabled` returns 'en it' i.e., the en locale is both enabled and disabled.
(In reply to Davide Pesavento from comment #12) > I think there's a bug in l10n.eclass (CC'ing maintainer). > > Let's assume that PLOCALES="en it", PLOCALE_BACKUP="en", and no LINGUAS are > enabled. The following happens: > `l10n_get_locales` returns 'en' > `l10n_get_locales disabled` returns 'en it' > i.e., the en locale is both enabled and disabled. Ben, did you have the time to look at this?
@yngwin, second ping.
(In reply to Davide Pesavento from comment #14) > @yngwin, second ping. Can we workaround this somehow until a proper fix is committed?
A workaround could be to just drop l10n eclass usage, it this case it looks like it's just controlling small text files anyway.
(In reply to Michael Palimaka (kensington) from comment #16) > A workaround could be to just drop l10n eclass usage, it this case it looks > like it's just controlling small text files anyway. Perhaps it's easier to bring back the -r0 ebuild as -r2
+ 23 Jun 2014; Sergey Popov <pinkbyte@gentoo.org> q4wine-1.1_p2-r1.ebuild: + Fix locale handling by using full locale names, wrt bug #496508. Minor QA + fixes. Thanks to Kjell Claesson <kjell.claesson AT epost.tidanet.se> for + discovering this issue Sorry for taking so long to fix this.
(In reply to Sergey Popov from comment #18) > + 23 Jun 2014; Sergey Popov <pinkbyte@gentoo.org> q4wine-1.1_p2-r1.ebuild: > + Fix locale handling by using full locale names, wrt bug #496508. Minor QA > + fixes. Thanks to Kjell Claesson <kjell.claesson AT epost.tidanet.se> for > + discovering this issue > > Sorry for taking so long to fix this. err.. what did you fix exactly? The real bug here is in the eclass (see my comment #12), did you fix that? if not, please open another bug so that we don't forget about it. P.S.: your commit introduced some unnecessary quoting.
ping?
Ben ping?
Please, either open a new bug for the eclass, or edit the summary. I'll have a look when I have a little more time, or when someone proposes a patch.
(In reply to Ben de Groot from comment #22) > Please, either open a new bug for the eclass, or edit the summary. > > I'll have a look when I have a little more time, or when someone proposes a > patch. Ok I opened #547790 for you.
Custom linguas handling disappeared since 1.3.
