Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496072 - x11-themes/gnome-themes-standard-3.8.4: Adwaita theme has incomplete menu borders
Summary: x11-themes/gnome-themes-standard-3.8.4: Adwaita theme has incomplete menu bor...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-26 14:09 UTC by ac.serbanescu
Modified: 2013-12-27 21:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot (Adwaita) (adwaita.png,120.20 KB, image/png)
2013-12-26 16:15 UTC, ac.serbanescu
Details
Screenshot (HighContrast) (highcontrast.png,31.19 KB, image/png)
2013-12-26 16:15 UTC, ac.serbanescu
Details
Screenshot (Adwaita under Mutter) (screenshot.png,271.51 KB, image/png)
2013-12-27 10:41 UTC, ac.serbanescu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ac.serbanescu 2013-12-26 14:09:47 UTC
Adwaita GTK3 theme menus do not have any border next to disabled/inactive menu items; the borders next to active items, separators etc. appear as they ought to. (I’m using gnome-themes-standard-3.8.4, gtk+-3.8.7, and no desktop environment; the window manager is fvwm.)

Also, could somebody please add a useflag to skip doing that symlink which makes Adwaita the default cursor theme? Or maybe one to skip installing the cursors altogether (the way -gtk skips the GTK theme itself)? I really don’t see why the default cursors need overriding.

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2013-12-26 15:58:18 UTC
Please provide an screenshot showing the problem
Comment 2 ac.serbanescu 2013-12-26 16:15:17 UTC
Created attachment 366228 [details]
Screenshot (Adwaita)
Comment 3 ac.serbanescu 2013-12-26 16:15:34 UTC
Created attachment 366230 [details]
Screenshot (HighContrast)
Comment 4 ac.serbanescu 2013-12-26 16:16:41 UTC
Here’s what I meant. It also happens with the HighContrast theme, as you can see (and it’s a lot more noticeable).
Comment 5 Pacho Ramos gentoo-dev 2013-12-26 16:58:40 UTC
Can you try on a newly created user account with a new home directory?
Comment 6 ac.serbanescu 2013-12-26 17:09:22 UTC
I did now. It looks the same way.
Comment 7 Pacho Ramos gentoo-dev 2013-12-26 17:11:59 UTC
I would report directly to upstream:
bugzilla.gnome.org
Comment 8 ac.serbanescu 2013-12-26 17:26:07 UTC
Done.

Could somebody consider the second thing too? It would only involve a trivial change to the ebuild.
Comment 9 Pacho Ramos gentoo-dev 2013-12-26 17:29:51 UTC
Do you have a link for upstream report?

The second issue is bug 416647
Comment 10 Evgeny Bobkin 2013-12-26 19:01:17 UTC
(In reply to ac.serbanescu from comment #0)
> Adwaita GTK3 theme menus do not have any border next to disabled/inactive
> menu items; the borders next to active items, separators etc. appear as they
> ought to. (I’m using gnome-themes-standard-3.8.4, gtk+-3.8.7, and no desktop
> environment; the window manager is fvwm.)
> 
> Also, could somebody please add a useflag to skip doing that symlink which
> makes Adwaita the default cursor theme? Or maybe one to skip installing the
> cursors altogether (the way -gtk skips the GTK theme itself)? I really don’t
> see why the default cursors need overriding.
> 
> Reproducible: Always

Looked at your screenshots, what theme are you using, the borders are not from Adwaita, neither menus in my opinion, is it a gnome session you are using?
Comment 11 ac.serbanescu 2013-12-26 20:37:33 UTC
For #9:

Yes, here it is: https://bugzilla.gnome.org/show_bug.cgi?id=721095

Too bad nobody would consider that thing (it makes reverting to the old cursors messy, and it gets redone each time you emerge it). Besides, there’s already a useflag that prevents the GTK themes from installing…

In response to #10:

But it should be Adwaita and not some other thing (or at least that’s what it says) since I got it from gnome-themes-standard and set it up with gtk-theme-name = Adwaita in my gtk-3.0/settings.ini file.

Maybe it’s the GNOME stuff that makes the menus look different (I wouldn’t know, since I don’t use it; I only use text sessions and I don’t run any graphical environment stuff except fvwm). But I did search for some screenshots and they looked quite similar.
Comment 12 Evgeny Bobkin 2013-12-26 21:37:25 UTC
(In reply to ac.serbanescu from comment #11)
> For #9:
> 
> Yes, here it is: https://bugzilla.gnome.org/show_bug.cgi?id=721095
> 
> Too bad nobody would consider that thing (it makes reverting to the old
> cursors messy, and it gets redone each time you emerge it). Besides, there’s
> already a useflag that prevents the GTK themes from installing…
> 
> In response to #10:
> 
> But it should be Adwaita and not some other thing (or at least that’s what
> it says) since I got it from gnome-themes-standard and set it up with
> gtk-theme-name = Adwaita in my gtk-3.0/settings.ini file.
> 
> Maybe it’s the GNOME stuff that makes the menus look different (I wouldn’t
> know, since I don’t use it; I only use text sessions and I don’t run any
> graphical environment stuff except fvwm). But I did search for some
> screenshots and they looked quite similar.

well, there is a Window theme and there is a Gtk+ theme and in Gnome they both are set to Adwaita. And your window theme is not Adwaita :-) I suspect that is has this side effect that menus do appear that bad. Therefore, I see it coming, that you upstream bug report will be closed as notagnome.
Comment 13 Evgeny Bobkin 2013-12-26 21:54:39 UTC
I am not sure if it leads somewhere, but what if you play with this settings:

$ gsettings get org.gnome.desktop.wm.preferences theme
'Adwaita'

Is is possible to set the window theme to Adwaita under fvwm?
gsettings set org.gnome.desktop.wm.preferences theme Adwaita

$ gsettings get org.gnome.desktop.interface gtk-theme
'Adwaita'
Comment 14 ac.serbanescu 2013-12-27 10:40:25 UTC
In reply to #12 and #13:

The window decoration stuff belongs to FVWM, made to look like CDE; I guess that’s what #12 meant. Actually, the window manager theme was already set to Adwaita in GSettings; however, this had no effect, since FVWM is themed in its own particular way and (as far as I know) it does not understand GSettings.

I did try the GNOME window managers. Metacity shows no difference and neither does Mutter. Despite the pretty stuff the latter draws around the menus, the original ‘broken’ borders are still visible, as it can be seen in the last screenshot.

It might still be a GTK+ glitch, even if it’s not strictly GNOME-related. Has anybody tried and/or managed to reproduce this running only X and some old-fashioned window manager?
Comment 15 ac.serbanescu 2013-12-27 10:41:57 UTC
Created attachment 366282 [details]
Screenshot (Adwaita under Mutter)
Comment 16 Pacho Ramos gentoo-dev 2013-12-27 10:49:10 UTC
Yes, I confirmed it with icewm ;)

We probably don't see it in Gnome because gnome-settings-daemon is running (and changing anything I expect upstream will be able to explain us :/)
Comment 17 Pacho Ramos gentoo-dev 2013-12-27 11:05:56 UTC
+*gnome-themes-standard-3.8.4-r1 (27 Dec 2013)
+
+  27 Dec 2013; Pacho Ramos <pacho@gentoo.org>
+  +files/gnome-themes-standard-3.8.4-menu-borders.patch,
+  +gnome-themes-standard-3.8.4-r1.ebuild:
+  Fix menu borders when not running with a composited WM (# by ac.serbanescu)
+
Comment 18 ac.serbanescu 2013-12-27 13:08:21 UTC
Thanks for the fix; it looks just fine now. But please, why won’t anyone make that dosym conditional upon use symlink or something like that? :)
Comment 19 Pacho Ramos gentoo-dev 2013-12-27 13:31:16 UTC
Well, it's a bit explained in referenced bug report (whose duplicates I saw came mostly from you). The ideal would be that X11 would honor settings from /etc (since user is supposed to configure things there instead of playing in /usr), that way we could still provide it as default but people could configure it from /etc 

Not sure if using INSTALL_MASK would work for you :|
Comment 20 ac.serbanescu 2013-12-27 15:20:26 UTC
So you saw that :)

Yes, but the trouble is that you can’t set cursors in /etc (actually you can, using Xresources, but you still can’t undo overriding the X11 ones, at least as far as I know…). So there’s no clean way to restore things once you install these new ones.
Comment 21 Pacho Ramos gentoo-dev 2013-12-27 21:18:29 UTC
And INSTALL_MASK to prevent installation of that file?