495042 – =app-emacs/apel-10.8-r1 has two src_prepare functions and a FILEDIR misspelling

Bug 495042 - =app-emacs/apel-10.8-r1 has two src_prepare functions and a FILEDIR misspelling

Summary: =app-emacs/apel-10.8-r1 has two src_prepare functions and a FILEDIR misspelling

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Mark Wright

URL:	http://sources.gentoo.org/cgi-bin/vie...
Whiteboard:
Keywords:

Depends on:
Blocks:	425258
	Show dependency tree

Reported:	2013-12-22 19:47 UTC by Tom Wijsman (TomWij) (RETIRED)
Modified:	2014-01-15 07:02 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Wijsman (TomWij) (RETIRED) gentoo-dev

2013-12-22 19:47:16 UTC

19: src_prepare() {
20: 	elisp_src_prepare
21: 	epatch "${FILESDIR}/${PN}-10.8-020_Prevent-fontset-error.patch"
22: 	epatch "${DISTDIR}/${PN}-10.8-030_Use-new-style-backquotes.patch"
23: 	epatch "${FILEDIR}/${PN}-10.8-010_ikazuhiro.patch"
24: 	epatch "${FILESDIR}/${PN}-10.8-040_make-temp-file-for-Emacs-24.3.50.patch"
25: }
26: 
27: src_prepare() {
28: 	elisp_src_prepare
29: 	cat <<-EOF >> APEL-CFG
30: 	(setq APEL_PREFIX "apel")
31: 	(setq EMU_PREFIX "apel")
32: 	EOF
33: }

src_prepare on line 27 overrides src_prepare on line 19, FILESDIR misspelled as FILEDIR on line 23; you might be able to make use of ELISP_PATCHES from elisp.eclass. (Found this while looking for unused patches.)

Comment 1 Mark Wright gentoo-dev

2014-01-15 07:02:10 UTC

Thanks for the fixes, applied: Apply fixes for bug 495042 suggested by TomWij (thanks): one src_prepare, correct FILESDIR mispelling, use ELISP_PATCHES.