Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 494448 - x11-libs/libqxt doesn't respect X11 event filters already set
Summary: x11-libs/libqxt doesn't respect X11 event filters already set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: http://dev.libqxt.org/libqxt/pull-req...
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2013-12-16 14:21 UTC by Georg Rudoy
Modified: 2013-12-17 11:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Invoke previous event filter on X11 (invoke_event_filters.patch,468 bytes, patch)
2013-12-16 14:29 UTC, Georg Rudoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Georg Rudoy 2013-12-16 14:21:17 UTC
libqxt doesn't invoke X11 event filters in its own event filtering procedure, breaking all event filters set before it sets its own.

There is a PR fixing the issue open for almost a month on their tracker, no reaction: http://dev.libqxt.org/libqxt/pull-request/41/

This thread in LeechCraft maillist may shed some additional light on the issue: https://groups.google.com/forum/#!topic/leechcraft/g5MAvc0JwJE

Reproducible: Always

Steps to Reproduce:
1. Install all of app-leechcraft/lc-{gacts,sb2,krigstask,azoth}.
2. Run LC with these modules.
Actual Results:  
Watch krigstask quark doesn't react to window state changes because Azoth module registers a global shortcut via GActs, which is using libqxt.

Expected Results:  
Krigstask should react to window state changes.
Comment 1 Georg Rudoy 2013-12-16 14:29:48 UTC
Created attachment 365470 [details, diff]
Invoke previous event filter on X11

This patch fixes the issue and is proposed to be added to the libqxt patchset in Gentoo.
Comment 2 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-12-16 14:36:41 UTC
(In reply to Georg Rudoy from comment #1)
> This patch fixes the issue and is proposed to be added to the libqxt
> patchset in Gentoo.

Why not upstream?
Comment 3 Georg Rudoy 2013-12-16 14:41:34 UTC
Cause upstream doesn't comment anything in a PR with a six-line diff in around a month and seems generally dead.

I also think of releasing a new version of LeechCraft in a few days. With the current state of libqxt it is either installed and breaks functionality of at least two plugins, or it should be avoided, breaking shortcuts in Azoth and LMP. Both solutions are unacceptable IMO.
Comment 4 Maxim Koltsov (RETIRED) gentoo-dev 2013-12-16 16:11:49 UTC
Personally, i agree with Georg that patch should be included in Gentoo patchset.

@qt: please review and make it so/give an OK.
Comment 5 Sergey Popov gentoo-dev 2013-12-17 11:21:59 UTC
+  17 Dec 2013; Sergey Popov <pinkbyte@gentoo.org> +libqxt-0.6.2-r1.ebuild,
+  +files/libqxt-0.6.2-fix-event-filters.patch:
+  Revision bump: EAPI 5, fix event filters handling, wrt bug #494448. Thanks to
+  Georg Rudoy <0xd34df00d AT gmail.com> for discovering this issue