Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493500 - dev-python/bsddb3: /bsddb3/tests dirs set for unwarranted removal
Summary: dev-python/bsddb3: /bsddb3/tests dirs set for unwarranted removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-07 07:58 UTC by Nikoli
Modified: 2014-04-01 11:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-12-07 07:58:22 UTC
python_install() {
        rm -fr "${ED}$(python_get_sitedir)/bsddb3/tests"

        if use doc; then
                dohtml -r docs/html/* || die "dohtml failed"
        fi
        distutils-r1_python_install
}

Migration to r1 python eclass was done incorrectly: /usr/lib64/python*/site-packages/bsddb3/tests/ are not removed, because they do not exist yet when rm command is executed. Both 5.3.0-r1 and 6.0.0 have this bug.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-08 12:09:27 UTC
Other notes:

1. PYTHON_CFLAGS is not used,

2. DOCS likely missing important files (based on old distutils.eclass appending behavior),

3. conditional tests are very ugly and need checking,

4. if tests are usable after install, they should not be removed,

5. mixing of global DOCS and local unconditional HTML_DOCS is pointless.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2014-04-01 11:24:09 UTC
(In reply to Michał Górny from comment #1)
> Other notes:
> 
> 1. PYTHON_CFLAGS is not used,
> 
seems it's not

> 2. DOCS likely missing important files (based on old distutils.eclass
> appending behavior),
They weren't but removed anyway, un-required.

> 3. conditional tests are very ugly and need checking,
> 
The source's code to run py3 is badly flawed.  Py3 run re-done totally.

> 4. if tests are usable after install, they should not be removed,
> 
seems they need not.

> 5. mixing of global DOCS and local unconditional HTML_DOCS is pointless.
Correct.

  01 Apr 2014; Ian Delaney <idella4@gentoo.org>+files/py3tests.patch,
  bsddb3-6.0.0.ebuild:
  install phase tidied, un-needed removal of tests folders removed, 
  test phase revised and fixed for py3 due to flaws in the source
  code's setup, includes the patch. Fixes Bugs #493500 by Nikoli and 
  #476246 by Patrick