Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493410 - media-gfx/dispcalgui-2.0.0.0 version bump
Summary: media-gfx/dispcalgui-2.0.0.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Marios Andreopoulos
URL: http://dispcalgui.hoech.net/#changelog
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-06 00:29 UTC by Bernard Cafarelli
Modified: 2014-05-08 18:47 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1.2.7.0 / 1.5.3.1 diff (dispcalGUI-1.5.3.diff,720 bytes, patch)
2013-12-08 04:36 UTC, Marios Andreopoulos
Details | Diff
dispcalgui 1.7.5.7 ebuild (dispcalgui-1.7.5.7.ebuild,2.21 KB, text/plain)
2014-03-04 19:00 UTC, Marios Andreopoulos
Details
wxversion select patch for 1.7.5.7 (dispcalgui-1.7.5.7-wxversion-select.patch,494 bytes, text/plain)
2014-03-04 19:02 UTC, Marios Andreopoulos
Details
dispcalgui-1.7.5.7.ebuild.diff (dispcalgui-1.7.5.7.ebuild.diff,1.92 KB, patch)
2014-03-18 22:56 UTC, Andreas Sturmlechner
Details | Diff
dispcalgui-1.2.7.0_to_2.0.0.0.patch (dispcalgui-1.2.7.0_to_2.0.0.0.patch,1.92 KB, patch)
2014-04-28 20:57 UTC, Marian Kyral
Details | Diff
dispcalgui-2.0.0.0-wxversion-select.patch (dispcalgui-2.0.0.0-wxversion-select.patch,494 bytes, patch)
2014-04-28 20:59 UTC, Marian Kyral
Details | Diff
dispcalgui-2.0.0.0.ebuild (dispcalgui-2.0.0.0.ebuild,2.10 KB, text/plain)
2014-05-06 04:55 UTC, Marian Kyral
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Cafarelli gentoo-dev 2013-12-06 00:29:47 UTC
Includes full argyllcms 1.6 support (I just added the bump to 1.6.2 in tree), and maybe more importantly finally remove the libpng warning popups :)

Tested with a colorhug and it ran fine

Also, source files (properly named) are available on sourceforge, so I used:
SRC_URI="mirror://sourceforge/${PN}/${MY_P}.tar.gz"
Comment 1 Marios Andreopoulos 2013-12-08 04:36:32 UTC
Created attachment 364896 [details, diff]
1.2.7.0 / 1.5.3.1 diff

Hello, thanks for the notice.

I just tested it and it works fine. Markos will do the bump.


@Markos
The differences between current dispcalgui 1.2.7.0 ebuild and new 1.5.3.1 are minimal, so I attached the diff.

I only changed the source URI as suggested by Bernard and adjusted the patch filename. I am not sure if there is a convention about patch naming. Feel free to rename if needed.

Thanks.
Comment 2 Andreas Sturmlechner gentoo-dev 2014-02-26 22:51:11 UTC
Meanwhile, dispcalgui-1.7.5.7 was released and 1.5.3.1 ebuild still works (minus the patch).
Comment 3 Marios Andreopoulos 2014-03-04 19:00:43 UTC
Created attachment 371730 [details]
dispcalgui 1.7.5.7 ebuild

Thanks for the notice. Probably Markos is very busy on other parts of Gentoo but the ebuild will get to portage eventually.

This is a new ebuild for the 1.7.5.7 version. Again changes are minimal, only a new patch was needed.
Comment 4 Marios Andreopoulos 2014-03-04 19:02:32 UTC
Created attachment 371732 [details]
wxversion select patch for 1.7.5.7

New ebuild needs a new patch to select wxversion. This is it.
Comment 5 Andreas Sturmlechner gentoo-dev 2014-03-18 22:56:54 UTC
Created attachment 372980 [details, diff]
dispcalgui-1.7.5.7.ebuild.diff

my attempt at silencing repoman about distutils-r1 migration
Comment 6 Marian Kyral 2014-04-28 20:57:36 UTC
Created attachment 375976 [details, diff]
dispcalgui-1.2.7.0_to_2.0.0.0.patch

Bump to version 2.0.0.0
Comment 7 Marian Kyral 2014-04-28 20:59:47 UTC
Created attachment 375978 [details, diff]
dispcalgui-2.0.0.0-wxversion-select.patch

wxversion patch - only renamed
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2014-05-05 14:14:07 UTC
Marios, are the 2.0.0.0 patches attached here good enough for inclusion?
Comment 9 Marios Andreopoulos 2014-05-05 23:04:32 UTC
The correct patch is from Andreas, attachment dispcalgui-1.7.5.7.ebuild.diff (372980).
This may be applied to 1.2.7.0 to create both 1.7.5.7 and 2.0.0.0 ebuilds. They only differ in name.

You also need the attachment dispcalgui-1.7.5.7-wxversion-select.patch (371732) from me.
You can name it as you want. If you keep its current name it will work with all ebuilds created from Andreas' patch. Generally this patch file outlasts the ebuild, so no reason to give it a name that reflects the current ebuild.

Marian's dispcalgui patch was created in the wrong order, it patches his 2.0.0.0 to 1.2.7.0. :)

I hope I didn't confuse you. In case I did:

$ cd path/to/media-gfx/dispcalgui
$ bugz attachment 372980 [details, diff]
$ patch < dispcalgui-1.7.5.7.ebuild.diff
$ mv dispcalgui-1.2.7.0.ebuild dispcalgui-2.0.0.0.ebuild
$ cd files
$ bugz attachment 371732 [details]
Comment 10 Marian Kyral 2014-05-06 04:52:46 UTC
(In reply to Marios Andreopoulos from comment #9)

> Marian's dispcalgui patch was created in the wrong order, it patches his
> 2.0.0.0 to 1.2.7.0. :)

jaj. That's why I like to attach whole ebuild instead of the patch :-D
Comment 11 Marian Kyral 2014-05-06 04:55:52 UTC
Created attachment 376462 [details]
dispcalgui-2.0.0.0.ebuild
Comment 12 Markos Chandras (RETIRED) gentoo-dev 2014-05-07 19:37:32 UTC
(In reply to Marios Andreopoulos from comment #9)
> The correct patch is from Andreas, attachment dispcalgui-1.7.5.7.ebuild.diff
> (372980).
> This may be applied to 1.2.7.0 to create both 1.7.5.7 and 2.0.0.0 ebuilds.
> They only differ in name.
> 
> You also need the attachment dispcalgui-1.7.5.7-wxversion-select.patch
> (371732) from me.
> You can name it as you want. If you keep its current name it will work with
> all ebuilds created from Andreas' patch. Generally this patch file outlasts
> the ebuild, so no reason to give it a name that reflects the current ebuild.
> 
> Marian's dispcalgui patch was created in the wrong order, it patches his
> 2.0.0.0 to 1.2.7.0. :)
> 
> I hope I didn't confuse you. In case I did:
> 
> $ cd path/to/media-gfx/dispcalgui
> $ bugz attachment 372980 [details, diff] [details, diff]
> $ patch < dispcalgui-1.7.5.7.ebuild.diff
> $ mv dispcalgui-1.2.7.0.ebuild dispcalgui-2.0.0.0.ebuild
> $ cd files
> $ bugz attachment 371732 [details]

I am slightly confused. Do we need both 1.7.5.7 and 2.0.0.0?
Comment 13 DrSlony 2014-05-08 06:07:49 UTC
Those ebuilds and patch renamed to 2.0.0.4 still compile, but 2.0.0.5 and 2.0.0.6 (the latter is the latest version at time of writing) and compilation fails:

 * Package:    media-gfx/dispcalgui-2.0.0.5
 * Repository: x-portage
 * USE:        amd64 elibc_glibc kernel_linux python_targets_python2_7 userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking dispcalGUI-2.0.0.5.tar.gz to /var/tmp/portage/media-gfx/dispcalgui-2.0.0.5/work
>>> Source unpacked in /var/tmp/portage/media-gfx/dispcalgui-2.0.0.5/work
>>> Preparing source in /var/tmp/portage/media-gfx/dispcalgui-2.0.0.5/work/dispcalGUI-2.0.0.5 ...
 * Applying dispcalgui-2.0.0.5-wxversion-select.patch ...                                                                                                                                                                                                                                                            [ ok ]
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-gfx/dispcalgui-2.0.0.5/work/dispcalGUI-2.0.0.5 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/media-gfx/dispcalgui-2.0.0.5/work/dispcalGUI-2.0.0.5 ...
 * python2_7: running distutils-r1_run_phase distutils-r1_python_compile
/usr/bin/python2.7 setup.py build
Traceback (most recent call last):
  File "setup.py", line 978, in <module>
    setup()
  File "setup.py", line 558, in setup
    if (not bdist_lipa and not zeroinstall and not buildservice) or sys.argv[1:]:
UnboundLocalError: local variable 'buildservice' referenced before assignment
 * ERROR: media-gfx/dispcalgui-2.0.0.5::x-portage failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line   93:  Called src_compile
 *   environment, line 3372:  Called distutils-r1_src_compile
 *   environment, line 1050:  Called _distutils-r1_run_foreach_impl 'distutils-r1_python_compile'
 *   environment, line  254:  Called python_parallel_foreach_impl 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 3236:  Called multibuild_parallel_foreach_variant '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 2388:  Called multibuild_foreach_variant '_multibuild_parallel' '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 2331:  Called _multibuild_run '_multibuild_parallel' '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 2329:  Called _multibuild_parallel '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 2379:  Called _python_multibuild_wrapper 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line  671:  Called distutils-r1_run_phase 'distutils-r1_python_compile'
 *   environment, line 1039:  Called distutils-r1_python_compile
 *   environment, line  922:  Called esetup.py 'build'
 *   environment, line 1489:  Called die
 * The specific snippet of code:
 *       "${@}" || die
Comment 14 Marios Andreopoulos 2014-05-08 11:41:07 UTC
(In reply to Markos Chandras from comment #12)
> I am slightly confused. Do we need both 1.7.5.7 and 2.0.0.0?

No, we only need 2.0.0.0.

(In reply to DrSlony from comment #13)
> Those ebuilds and patch renamed to 2.0.0.4 still compile, but 2.0.0.5 and
> 2.0.0.6 (the latter is the latest version at time of writing) and
> compilation fails:

These aren't release versions but daily snapshots. Once there is a release, we will see what we can do. :)
Comment 15 Markos Chandras (RETIRED) gentoo-dev 2014-05-08 18:47:40 UTC
(In reply to Marios Andreopoulos from comment #9)
> The correct patch is from Andreas, attachment dispcalgui-1.7.5.7.ebuild.diff
> (372980).
> This may be applied to 1.2.7.0 to create both 1.7.5.7 and 2.0.0.0 ebuilds.
> They only differ in name.
> 
> You also need the attachment dispcalgui-1.7.5.7-wxversion-select.patch
> (371732) from me.
> You can name it as you want. If you keep its current name it will work with
> all ebuilds created from Andreas' patch. Generally this patch file outlasts
> the ebuild, so no reason to give it a name that reflects the current ebuild.
> 
> Marian's dispcalgui patch was created in the wrong order, it patches his
> 2.0.0.0 to 1.2.7.0. :)
> 
> I hope I didn't confuse you. In case I did:
> 
> $ cd path/to/media-gfx/dispcalgui
> $ bugz attachment 372980 [details, diff] [details, diff]
> $ patch < dispcalgui-1.7.5.7.ebuild.diff
> $ mv dispcalgui-1.2.7.0.ebuild dispcalgui-2.0.0.0.ebuild
> $ cd files
> $ bugz attachment 371732 [details]

I renamed the wxversion-select.patch to 2.0.0.0 because there is no 1.7.5.7 ebuild in the tree.

Committed with that change. Thanks a lot and apologies for the delay.


+*dispcalgui-2.0.0.0 (08 May 2014)
+
+  08 May 2014; Markos Chandras <hwoarang@gentoo.org>
+  +dispcalgui-2.0.0.0.ebuild, +files/dispcalgui-2.0.0.0-wxversion-select.patch:
+  Version bump. Bug #493410. Thanks to Andreas Sturmlechner
+  <andreas.sturmlechner@gmail.com> and Marios Andreopoulos
+  <opensource@andmarios.com>
+