Bug 493108 – app-admin/cdist - a usable configuration management system

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thomas Oettli 2013-12-02 08:42:14 UTC]

Created attachment 364422 [details]
app-admin/cdist-2.3.6.ebuild

cdist is a usable configuration management system. It adheres to the KISS principle and is being used in small up to enterprise grade environments. cdist is an alternative to other configuration management systems like bcfg2, chef, cfengine and puppet.

see http://http://www.nico.schottelius.org/software/cdist/

It is the only configuration management tool which doesn't have any dependencies on the target hosts except SSH and a shell.

Please add it to the portage tree.

[Comment 1 Thomas Oettli 2013-12-02 08:44:00 UTC]

Created attachment 364424 [details]
cdist-2.3.6.ebuild

Now in testing ;-)

[Comment 2 Daniel Heule 2014-01-09 15:38:06 UTC]

Created attachment 367486 [details]
cdist-3.0.0.ebuild

[Comment 3 Markos Chandras (RETIRED) 2014-01-09 18:57:42 UTC]

Hi,

The ebuild looks trivial enough. I have two questions

1) Why rm cdist/conf/.gitignore? If it is not strictly necessary we can remove that line and src_prepare altogether.

2) in src_install, we usually do the actual installation first and then install the documentation. So 'doman' should be moved after distutils-r1_src_install. But that's not a problem.

I can fix that myself before committing it but i am mostly interested in point #1

[Comment 4 Daniel Heule 2014-01-09 19:31:02 UTC]

Hi,

1) This is only to have a clean system after install,
but i try to fix it in the next upstream release.

2) Thx for the info, so please change the the order off the statements.

[Comment 5 Markos Chandras (RETIRED) 2014-01-09 20:21:02 UTC]

(In reply to Daniel Heule from comment #4)
> Hi,
> 
> 1) This is only to have a clean system after install,
> but i try to fix it in the next upstream release.
> 
Do you mean that the .gitignore file gets installed and that's why you need to remove it?

[Comment 6 Markos Chandras (RETIRED) 2014-01-09 20:22:38 UTC]

Another thing that I forgot to mention was that in the DESCRIPTION field we don't usually repeat the name of that package because of the recursive description

"foo is a bar" does not really describe "foo" ;)

I will change it to

"A usable configuration management system"

[Comment 7 Daniel Heule 2014-01-09 20:34:55 UTC]

(In reply to Markos Chandras from comment #5)
> (In reply to Daniel Heule from comment #4)
> > Hi,
> > 
> > 1) This is only to have a clean system after install,
> > but i try to fix it in the next upstream release.
> > 
> Do you mean that the .gitignore file gets installed and that's why you need
> to remove it?

Jep.

[Comment 8 Daniel Heule 2014-01-09 20:35:53 UTC]

(In reply to Markos Chandras from comment #6)
> Another thing that I forgot to mention was that in the DESCRIPTION field we
> don't usually repeat the name of that package because of the recursive
> description
> 
> "foo is a bar" does not really describe "foo" ;)
> 
> I will change it to
> 
> "A usable configuration management system"

Ok, for the next time i know it

[Comment 9 Markos Chandras (RETIRED) 2014-01-09 20:43:55 UTC]

Another comment (sorry just looking at these as i do a final review)

DOCS=$(use doc && echo README)

no no no

$(use..) must not be used in global scope. It breaks the metadata cache
http://devmanual.gentoo.org/general-concepts/portage-cache/index.html

I see no problem installing the README file unconditionally. 

As far as the HTML_DOCS are concerned, the same problem exists there.

I assume one way to fix this is something like this



src_install() {
        if use doc; then
            HTML_DOCS="docs/man/man1/*.html docs/man/man7/*.html"

	doman docs/man/man1/*.1 docs/man/man7/*.7
	distutils-r1_src_install
}

[Comment 10 Daniel Heule 2014-01-09 21:14:28 UTC]

Created attachment 367514 [details]
cdist-3.0.0.ebuild

[Comment 11 Daniel Heule 2014-01-09 21:18:09 UTC]

(In reply to Markos Chandras from comment #9)
> Another comment (sorry just looking at these as i do a final review)
> 
> DOCS=$(use doc && echo README)
> 
> no no no
> 
> $(use..) must not be used in global scope. It breaks the metadata cache
> http://devmanual.gentoo.org/general-concepts/portage-cache/index.html
> 
> I see no problem installing the README file unconditionally. 
> 
> As far as the HTML_DOCS are concerned, the same problem exists there.
> 
> I assume one way to fix this is something like this
> 
> 
> 
> src_install() {
>         if use doc; then
>             HTML_DOCS="docs/man/man1/*.html docs/man/man7/*.html"
> 
> 	doman docs/man/man1/*.1 docs/man/man7/*.7
> 	distutils-r1_src_install
> }

I have read the link about the portage-cache,
sorry for my fault, a new version is submitted.

[Comment 12 Markos Chandras (RETIRED) 2014-01-09 21:23:10 UTC]

Committed with the fixes we discussed.

+*cdist-3.0.0 (09 Jan 2014)
+
+  09 Jan 2014; Markos Chandras <[e-mail]> +cdist-3.0.0.ebuild,
+  +metadata.xml:
+  Initial commit. Ebuild by Daniel Heule <[e-mail]> who will maintain it.
+  Bug #493108
+

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/cdist/cdist-3.0.0.ebuild?revision=1.1&view=markup

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/cdist/metadata.xml?revision=1.1&view=markup