Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493036 - net-misc/memcached - enable socket support in init and conf scripts
Summary: net-misc/memcached - enable socket support in init and conf scripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-12-01 15:41 UTC by Anthony Ryan
Modified: 2013-12-23 00:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
init file (file_493036.txt,2.29 KB, text/plain)
2013-12-01 15:45 UTC, Anthony Ryan
Details
conf file (file_493036.txt,912 bytes, text/plain)
2013-12-01 15:48 UTC, Anthony Ryan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ryan 2013-12-01 15:41:33 UTC
Presently the init & conf that come with the memcached ebuild lacks correct support for running memcached on a socket.

This of course could always be worked around by using the MISC_OPTS included in the config file, but the init script still (incorrectly) warned that it was an insecure way of running memcached, when keeping it on a unix socket can be done more securely than network + firewall constraints.

Attached is an update to the init and conf file for this service adding proper support for sockets. I also took this as an opportunity to fix the haphazard indentation and tidy it up.

There is one potential issue with my changes, I have changed the location of the PID file to remove the PORT from it by default for two reasons.

1. When running memcached on a socket, there is no port
2. Multiple concurrent running versions of memcached already have their PIDs tagged with the CONF variable.

I could not think of any use cases this may break but would appreciate feedback if I'm overlooking something.

Reproducible: Always
Comment 1 Anthony Ryan 2013-12-01 15:45:32 UTC
Created attachment 364334 [details]
init file
Comment 2 Anthony Ryan 2013-12-01 15:48:03 UTC
Created attachment 364336 [details]
conf file
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-12-23 00:56:47 UTC
fixed in tree as 1.4.17