Bug 492976 – >=app-arch/lrzip-0.614: missing #include <stdarg.h>

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2013-11-30 20:08:12 UTC]

In recent versions of lrzip, Lrzip.h makes use of variadic va_list but doesn't include <stdarg.h>.  This doesn't lead to a problem on a glib system because of the way headers stack, but on uclibc and probalby other libc's this causes the build to fail with

  CC       decompress_demo.o
In file included from decompress_demo.c:26:0:
./Lrzip.h:134:119: error: unknown type name 'va_list'
In file included from decompress_demo.c:26:0:
./Lrzip.h:505:34: error: unknown type name 'Lrzip_Log_Cb'
make[2]: *** [decompress_demo.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/app-arch/lrzip-0.614/work/lrzip-0.614'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/app-arch/lrzip-0.614/work/lrzip-0.614'
make: *** [all] Error 2


The fix is pretty simple:

diff -Naur Lrzip.h.orig Lrzip.h
--- Lrzip.h.orig	2013-11-30 20:07:27.343086997 +0000
+++ Lrzip.h	2013-11-30 20:07:44.072641056 +0000
@@ -22,6 +22,7 @@
 
 #include <stdbool.h>
 #include <stdio.h>
+#include <stdarg.h>
 #ifdef _WIN32
 # include <stddef.h>
 #else


Reproducible: Always

[Comment 1 Anthony Basile 2013-12-20 15:37:01 UTC]

ping

[Comment 2 Anthony Basile 2014-01-07 17:22:45 UTC]

(In reply to Anthony Basile from comment #1)
> ping

ping again ... man 3 stdarg.  I did email [e-mail] with no response.

[Comment 3 Ben de Groot (RETIRED) 2014-01-08 06:53:41 UTC]

feel free to apply

[Comment 4 Anthony Basile 2014-01-08 14:37:06 UTC]

(In reply to Ben de Groot from comment #3)
> feel free to apply

Done, thanks.  I just noticed your on devaway.