Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492834 - sys-apps/man-pages - Add subslots and depend on them in app-i18n/man-pages-de
Summary: sys-apps/man-pages - Add subslots and depend on them in app-i18n/man-pages-de
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-29 09:28 UTC by Markus Walter
Modified: 2018-06-26 16:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for sys-apps/man-pages (0001-Bump-to-EAPI-5-and-add-subslots.patch,21.92 KB, patch)
2013-11-29 09:28 UTC, Markus Walter
Details | Diff
ebuild with subslot dependency (man-pages-de-1.3-r1.ebuild,1.40 KB, text/plain)
2013-11-29 09:28 UTC, Markus Walter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Walter 2013-11-29 09:28:36 UTC
Created attachment 364176 [details, diff]
patch for sys-apps/man-pages

Don't know whether I should add a long introduction: I proxy-maintain man-pages-de.

Adding subslots to man-pages requires an EAPI-bump. I searched the archives and it looks like this does not require a revbump. This can be accomplished with the attached patch.

We then can add a subslot dependency on man-pages in man-pages-de as in the attached ebuild, which causes man-pages-de to be now in sync with man-pages.
Comment 1 Markus Walter 2013-11-29 09:28:58 UTC
Created attachment 364178 [details]
ebuild with subslot dependency
Comment 2 SpanKY gentoo-dev 2013-11-29 14:06:38 UTC
Comment on attachment 364176 [details, diff]
patch for sys-apps/man-pages

we're not doing EAPI=5 here yet, nor are we hardcoding $PV in a variable that could just as easily use $PV

the man-pages-de could just depend on ~man-pages-$PV and largely get the same behavior.  i don't think it's critical enough to warrant bumping man-pages for now.
Comment 3 Markus Walter 2013-11-29 14:19:28 UTC
(In reply to SpanKY from comment #2)
> Comment on attachment 364176 [details, diff] [details, diff]
> patch for sys-apps/man-pages
> 
> we're not doing EAPI=5 here yet, nor are we hardcoding $PV in a variable
> that could just as easily use $PV
> 
> the man-pages-de could just depend on ~man-pages-$PV and largely get the
> same behavior.  i don't think it's critical enough to warrant bumping
> man-pages for now.

Agreed, that SLOT="0/$PV" would be better. But depending on ~man-pages-$PV does not seem to be a good solution, since there is no correspondence between versions of man-pages and man-pages-de. Thus man-pages-de would have to be bumped needlessly with every man-pages release.

Would moving to EAPI=5 hurt anything?
Comment 4 SpanKY gentoo-dev 2018-06-26 03:44:43 UTC
remind me ... why is this necessary ?  what does a subslot gain us here ?  it's not link man-pages-de is "linking" against man-pages, or otherwise changes its output/installed files when man-pages upgrades.

man-pages depends on man-pages-de when the user has the "de" language active, both of which would normally get upgraded during @world and such.
Comment 5 Markus Walter 2018-06-26 16:54:07 UTC
(In reply to SpanKY from comment #4)
> remind me ... why is this necessary ?  what does a subslot gain us here ? 
> it's not link man-pages-de is "linking" against man-pages, or otherwise
> changes its output/installed files when man-pages upgrades.
> 
> man-pages depends on man-pages-de when the user has the "de" language
> active, both of which would normally get upgraded during @world and such.

In the past man-pages-de used the installed man-pages to generate the translations. This has changed in the meantime, so this is now obsolete.