Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492700 - dev-util/visual-regexp-3.0-r1 - several patches
Summary: dev-util/visual-regexp-3.0-r1 - several patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Quentin Minster
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-11-27 13:48 UTC by Quentin Minster
Modified: 2013-12-15 18:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild bumped to EAPI 5 (visual-regexp-3.0.ebuild,1.08 KB, text/plain)
2013-11-27 13:53 UTC, Quentin Minster
Details
help font patch (visual-regexp-3.0-help-font-fix.patch,994 bytes, patch)
2013-11-27 13:55 UTC, Quentin Minster
Details | Diff
~/.visual_regexp config patch (visual-regexp-3.0-home-conf-fix.patch,1.75 KB, patch)
2013-11-27 13:55 UTC, Quentin Minster
Details | Diff
pattern file loading patch (visual-regexp-3.0-pattern-load-fix.patch,891 bytes, patch)
2013-11-27 13:56 UTC, Quentin Minster
Details | Diff
renamed wish-fix patch (visual-regexp-3.0-wish-fix.patch,405 bytes, patch)
2013-11-27 13:56 UTC, Quentin Minster
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Minster 2013-11-27 13:48:57 UTC
Revision bump for ebuild dev-util/visual-regexp-3.0 with the following bugfixes and enhancements:
* visual-regexp-3.0-help-font-fix.patch: fix font issues in help page
* visual-regexp-3.0-pattern-load-fix.patch: fix pattern file loading
* visual-regexp-3.0-wish-fix.patch: simple rename of wish-fix.patch (to match naming scheme of other patches ; also to prevent collision with upcoming visual-regexp-3.1-wish-fix.patch)
* visual-regexp-3.0-home-conf-fix.patch: load pattern/ini files from ~/.visual_regexp (in addition to pwd) + fix init order

Reproducible: Always

Steps to Reproduce:
help-font-fix: opening the help page triggers an error

pattern-load-fix: "Insert regexp" > "Load patterns..." then loading a newline-terminated pattern file (something as simple as "a b") causes visual-regexp to hang

home-conf-fix: creating a pattern file (after applying previous patch) in current directory then starting visual-regexp from there triggers an error (since GUI is uninitialized)
Comment 1 Quentin Minster 2013-11-27 13:53:51 UTC
Created attachment 364070 [details]
ebuild bumped to EAPI 5

also moved dev-lang/tk from DEPEND to RDEPEND (since there's no compile step)
Comment 2 Quentin Minster 2013-11-27 13:55:21 UTC
Created attachment 364072 [details, diff]
help font patch
Comment 3 Quentin Minster 2013-11-27 13:55:46 UTC
Created attachment 364074 [details, diff]
~/.visual_regexp config patch
Comment 4 Quentin Minster 2013-11-27 13:56:03 UTC
Created attachment 364076 [details, diff]
pattern file loading patch
Comment 5 Quentin Minster 2013-11-27 13:56:20 UTC
Created attachment 364078 [details, diff]
renamed wish-fix patch
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2013-11-27 13:59:52 UTC
Comment on attachment 364070 [details]
ebuild bumped to EAPI 5

--- visual-regexp-3.0.ebuild    2012-09-06 17:13:17.000000000 +0200
+++ -   2013-11-27 14:59:43.464881815 +0100
@@ -1,8 +1,8 @@
-# Copyright 1999-2012 Gentoo Foundation
+# Copyright 1999-2013 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-util/visual-regexp/visual-regexp-3.0.ebuild,v 1.9 2012/09/05 09:45:09 jlec Exp $
 
-EAPI=4
+EAPI=5
 
 inherit eutils
 
@@ -17,13 +17,17 @@
 KEYWORDS="~amd64 ~ppc ~x86"
 IUSE=""
 
-DEPEND="dev-lang/tk"
-RDEPEND="${DEPEND}"
+DEPEND=""
+RDEPEND=">=dev-lang/tk-8.3"
 
 S=${WORKDIR}/visual_regexp-${PV}
 
 src_prepare() {
-       epatch "${FILESDIR}"/wish-fix.diff
+       epatch \
+               "${FILESDIR}"/visual-regexp-3.0-wish-fix.patch \
+               "${FILESDIR}"/visual-regexp-3.0-help-font-fix.patch \
+               "${FILESDIR}"/visual-regexp-3.0-home-conf-fix.patch \
+               "${FILESDIR}"/visual-regexp-3.0-pattern-load-fix.patch
 }
 
 src_install() {
Comment 7 Quentin Minster 2013-11-27 14:04:00 UTC
Hmm got the file names wrong, didn't thought the "describe" field of the attachments would be used this way.
So the correct names (matching my above description) should be:
* visual-regexp-3.0.ebuild = "ebuild bumped to EAPI 5"
* visual-regexp-3.0-help-font-fix.patch = "help font patch"
* visual-regexp-3.0-home-conf-fix.patch = "~/.visual_regexp config patch"
* visual-regexp-3.0-pattern-load-fix.patch = "pattern file loading patch"
* visual-regexp-3.0-wish-fix.patch = "renamed wish-fix patch"
Comment 8 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-12-15 18:56:37 UTC
+  15 Dec 2013; Tom Wijsman <TomWij@gentoo.org>
+  +files/visual-regexp-3.0-help-font-fix.patch,
+  +files/visual-regexp-3.0-home-conf-fix.patch,
+  +files/visual-regexp-3.0-pattern-load-fix.patch,
+  +files/visual-regexp-3.0-wish-fix.patch, +visual-regexp-3.0-r1.ebuild:
+  Revision bump, several fixes from bug #492700; proxied commit for Quentin
+  Minster (laomaiweng).