Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 491782 - media-libs/libgphoto2-2.5.2 supports only 527 cameras instead of 1451
Summary: media-libs/libgphoto2-2.5.2 supports only 527 cameras instead of 1451
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-11-20 15:54 UTC by Nikoli
Modified: 2013-11-23 10:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
LANG=C gphoto2 --list-cameras > /tmp/cameras_libgphoto2-2.5.2 (cameras_libgphoto2-2.5.2,14.16 KB, text/plain)
2013-11-20 15:54 UTC, Nikoli
Details
LANG=C gphoto2 --list-cameras > /tmp/cameras_libgphoto2-2.4.14-r1 (cameras_libgphoto2-2.4.14-r1,38.38 KB, text/plain)
2013-11-20 15:55 UTC, Nikoli
Details
better libxml2 detection from upstream 1 (libgphoto-2.5.2-libxml2-detection.patch,1.13 KB, patch)
2013-11-21 15:00 UTC, Evgeny Bobkin
Details | Diff
better libxml2 detection from upstream for ptp.c (libgphoto-2.5.2-libxml2-detection-ptp.patch,579 bytes, patch)
2013-11-21 15:01 UTC, Evgeny Bobkin
Details | Diff
r14415 (libgphoto2-2.5.2-detect-libxml2.patch,2.40 KB, patch)
2013-11-23 10:18 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-11-20 15:54:20 UTC
Created attachment 363674 [details]
LANG=C gphoto2 --list-cameras > /tmp/cameras_libgphoto2-2.5.2

'gphoto2 --list-cameras' for libgphoto2-2.4.14-r1 shows 1451 cameras, but for 2.5.2 it shows only 527. For me gphoto 2.5.2 is useless now: all my devices are not supported.

Portage 2.2.7 (hardened/linux/amd64, gcc-4.7.3, glibc-2.15-r3, 3.11.6-hardened-r1 x86_64)
=================================================================
                        System Settings
=================================================================
KiB Mem:    65825872 total,  35243096 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Wed, 20 Nov 2013 14:15:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.5-r3
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.69
sys-devel/automake:       1.13.4
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo nikoli
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=corei7-avx -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0 /usr/share/themes/oxygen-gtk/gtk-3.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=corei7-avx -O2 -pipe"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTDIR_OVERLAY="/var/lib/layman/nikoli"
USE="X a52 aac acl acpi aes-ni alsa amd64 amr audiofile avx bash-completion bzip2 cairo caps cdda cddb cdio cdparanoia cdr celt cli consolekit cracklib crypt css cups cxx dbus djvu dri dts dv dvd dvdr encode exif fat ffmpeg flac fluidsynth fontconfig fortran gd geoip gif gimp gmp gnutls gphoto2 gpm graphviz gsm gstreamer gtk handbook hardened iconv icu id3tag idn ilbc imagemagick imap imlib ios ipod ipv6 jbig jpeg jpeg2k justify kde kipi lame laptop lcms libass libnotify libproxy libsamplerate lm_sensors lzma lzo mac mad matroska mikmod mmx mmxext modplug modules mp3 mp4 mpeg mtp mudflap multilib musepack musicbrainz ncurses networkmanager nls nptl nptlonly ntfs ogg openal openexr opengl openmp opus pam pango pax_kernel pcre pdf pg-intdatetime phonon plasma pm-utils png policykit postscript qt3support qt4 quicktime rar raw readline reiserfs replaygain rtmp sasl scanner semantic-desktop session sid smp sndfile socks5 speex spell sqlite sse sse2 sse3 sse4_1 ssl ssse3 startup-notification svg symlink sysfs taglib theora threads thumbnail tiff truetype tta udev udisks unicode upnp upower usb v4l v4l2 vcd vdpau vorbis vpx wavpack webkit webp wifi wma wmf x264 xattr xcb xcomposite xface xinerama xml xmp xpm xscreensaver xv xvid xz zip zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-minimizer" LINGUAS="ru ru_RU en" NGINX_MODULES_HTTP="access auth_basic autoindex fastcgi gzip rewrite" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="i386 x86_64" RUBY_TARGETS="ruby20" USERLAND="GNU" VIDEO_CARDS="radeon r600 modesetting vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

media-libs/libgphoto2-2.5.2 was built with the following:
USE="exif gd jpeg nls -doc -examples -zeroconf" CAMERAS="adc65 agfa_cl20 aox ax203 barbie canon casio_qv clicksmart310 digigr8 digita dimagev dimera3500 directory enigma13 fuji gsmart300 hp215 iclick jamcam jd11 jl2005a jl2005c kodak_dc120 kodak_dc210 kodak_dc240 kodak_dc3200 kodak_ez200 konica konica_qm150 largan lg_gsm mars mustek panasonic_coolshot panasonic_dc1000 panasonic_dc1580 panasonic_l859 pccam300 pccam600 polaroid_pdc320 polaroid_pdc640 polaroid_pdc700 ptp2 ricoh ricoh_g3 samsung sierra sipix_blink sipix_blink2 sipix_web2 smal sonix sony_dscf1 sony_dscf55 soundvision spca50x sq905 st2205 stv0674 stv0680 sx330z template topfield toshiba_pdrm11 tp6801"
Comment 1 Nikoli 2013-11-20 15:55:14 UTC
Created attachment 363676 [details]
LANG=C gphoto2 --list-cameras > /tmp/cameras_libgphoto2-2.4.14-r1
Comment 2 Nikoli 2013-11-20 16:38:34 UTC
With 2.4.14:
$ /usr/lib64/libgphoto2/print-camera-list udev-rules version 136 group plugdev|wc -l
1306

With 2.5.2:
$ /usr/lib64/libgphoto2/print-camera-list udev-rules version 136 group plugdev|wc -l
383

/lib/udev/rules.d/70-libgphoto2.rules has much less rules after update.
Comment 3 Nikoli 2013-11-20 17:15:35 UTC
Rebuilding with libxml2 enabled solved problem:
Number of supported cameras: 1711

So we have 2 bugs here:
1) ebuild has missing libxml2 RDEPEND
2) Build system fails to detect libxml2 headers, because it is not using pkg-config and is looking for /usr/include/libxml/parser.h. Gentoo has /usr/include/libxml2/libxml/parser.h
I used symlink as tmp workaround:
pushd /usr/include/
ln -s libxml2/libxml libxml
Comment 4 Nikoli 2013-11-20 17:24:35 UTC
Other bugs and suggestion for 2.5.2 ebuild:
1) --without-hal option was removed, even 2.4.14 does not have it
2) --with-drivers= was renamed to --with-camlibs=
3) Use udev 175 mode for print-camera-list isntead of 136, it was added in 2.4.14, minimal version of udev in portage tree now is 204.
4) IUSE_CAMERAS needs updating: add pentax, remove sipix_blink and template.
Comment 5 Evgeny Bobkin 2013-11-20 19:18:28 UTC
Nice investigations of you
(In reply to Nikoli from comment #3)
> Rebuilding with libxml2 enabled solved problem:
> Number of supported cameras: 1711
> 
> So we have 2 bugs here:
> 1) ebuild has missing libxml2 RDEPEND
> 2) Build system fails to detect libxml2 headers, because it is not using
> pkg-config and is looking for /usr/include/libxml/parser.h. Gentoo has
> /usr/include/libxml2/libxml/parser.h
The proper way in my opinion is to patch it with the pkg-config and try to land it upstream :-) instead of creating a symlink
> I used symlink as tmp workaround:
> pushd /usr/include/
> ln -s libxml2/libxml libxml
Comment 6 Nikoli 2013-11-20 19:27:04 UTC
Sure, i did so only for quick checking if it will solve my problem with missing cameras.
Comment 7 Pacho Ramos gentoo-dev 2013-11-21 06:52:26 UTC
http://sourceforge.net/p/gphoto/bugs/953/

This looks to be the upstream report about this... but I wonder if its attached patch is correct :|

Also got surprised --enable-option-checking needs to be explicitly added to get the warnings about the missing configure options :O

Thanks for the report and finding the issues, will try to take care of this when I have time (if nobody beats me), but would like a bit of help with the libxml2 detection issue :/
Comment 8 Evgeny Bobkin 2013-11-21 14:10:13 UTC
the current configuration indeed reports 
...
checking for xmlFirstElementChild in -lxml2... yes
checking libxml/parser.h usability... no
checking libxml/parser.h presence... no
checking for libxml/parser.h... no
...

there an improvement upstream available:

http://sourceforge.net/p/gphoto/code/14416/tree/trunk/libgphoto2/configure.ac?diff=50c8ee315fcbc9098bbba8e5:14408&diformat=regular
Comment 9 Evgeny Bobkin 2013-11-21 14:43:15 UTC
with this patch I gain the libxml detection

checking for libxml-2.0 to use... autodetect
checking for LIBXML2... yes
checking libxml/parser.h usability... yes
checking libxml/parser.h presence... yes
checking for libxml/parser.h... yes
checking for function xmlFirstElementChild in libxml-2.0... yes
checking libxml-2.0 library flags... "-lxml2 "
checking libxml-2.0 cpp flags... "-I/usr/include/libxml2 "
checking for dirent.h that defines DIR... yes
checking for library containing opendir... none required

and 

  libxml2 support
    libxml-2.0:                    yes


however the compilation fails with

../gphoto2/gphoto2-file.h:129:5: note: expected 'char *' but argument is of type 'unsigned char *'
ptp2/ptp.c:30:28: fatal error: libxml/parser.h: No such file or directory
compilation terminated.
make[3]: *** [ptp2/ptp.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

so I assume this second patch from upstream is also needed

http://sourceforge.net/p/gphoto/code/14415/tree//trunk/libgphoto2/camlibs/ptp2/Makefile-files?diff=50c8ee315fcbc9098bbba8e5:14414
Comment 10 Evgeny Bobkin 2013-11-21 15:00:57 UTC
Created attachment 363728 [details, diff]
better libxml2 detection from upstream 1
Comment 11 Evgeny Bobkin 2013-11-21 15:01:32 UTC
Created attachment 363730 [details, diff]
better libxml2 detection from upstream for ptp.c
Comment 12 Evgeny Bobkin 2013-11-21 15:09:19 UTC
With this both patches appied libxml2 support seems to be properly detected and built
Comment 13 Pacho Ramos gentoo-dev 2013-11-22 21:00:12 UTC
+*libgphoto2-2.5.2-r1 (22 Nov 2013)
+
+  22 Nov 2013; Pacho Ramos <pacho@gentoo.org>
+  +files/libgphoto2-2.5.2-libxml2-detection.patch,
+  +files/libgphoto2-2.5.2-libxml2-detection2.patch, +libgphoto2-2.5.2-r1.ebuild,
+  -libgphoto2-2.5.2.ebuild:
+  Apply important fixes: solve libxml2 detection, update configure options, rely
+  on udev >= 175, update cameras (#484276 by Nikoli and Evgeny Bobkin, also
+  solving #484276 by Michael Rowell); drop old.
+
Comment 14 Nikoli 2013-11-23 10:18:34 UTC
Created attachment 363822 [details, diff]
r14415

Evgeny, thanks for finding upstream changes, but you used wrong way for extracting them. Both attached patches are from same commit:
http://sourceforge.net/p/gphoto/code/14415/

Correct way to create patches from svn commits:
svn diff -c 14415 svn://svn.code.sf.net/p/gphoto/code/trunk > libgphoto2-2.5.2-detect-libxml2.patch

I think it is better to merge both patches into one, no need for having 2.