Bug 491246 – Missing prefix in /usr/lib/portage/bin/phase-helpers.sh

• Status: RESOLVED NEEDINFO
• Product: Portage Development

[Description Thierry Schuepbach 2013-11-14 15:56:54 UTC]

Within einstall function in file /usr/lib/portage/bin/phase-helpers.sh, there should be a ${ED} instead of the actual ${D}. The line unfortunately changes between portage projects. Look in the code below on the second line.

Hence prefix is not correctly being used.
Nevertheless I believe this part of the code is hardly being used as it deals specific ebuils passing --bindir.


if [ -n "${CONF_LIBDIR}" ] && [ "${CONF_PREFIX:+set}" = set ]; then
        EI_DESTLIBDIR="${D}/${CONF_PREFIX}/${CONF_LIBDIR}"
        EI_DESTLIBDIR="$(__strip_duplicate_slashes "${EI_DESTLIBDIR}")"
        LOCAL_EXTRA_EINSTALL="libdir=${EI_DESTLIBDIR} ${LOCAL_EXTRA_EINSTALL}"
        unset EI_DESTLIBDIR
fi

[Comment 1 Thierry Schuepbach 2013-11-14 16:02:39 UTC]

Created attachment 363262 [details, diff]
Patch to correct missing prefix

[Comment 2 Sebastian Luther (few) 2013-11-25 11:43:00 UTC]

@prefix: Could you comment on this?

[Comment 3 Fabian Groffen 2013-11-25 12:17:46 UTC]

depends on CONF_PREFIX, if it never includes EPREFIX, then the patch seems fine

[Comment 4 Sebastian Luther (few) 2013-11-26 13:20:15 UTC]

Could you give me instructions how to reproduce this?

[Comment 5 Fabian Groffen 2013-11-29 20:43:50 UTC]

The code seems to include EPREFIX in CONF_PREFIX, or assume it is (--exec-prefix=/--prefix= arguments), so if CONF_PREFIX doesn't include EPREFIX (hence you having to use ED) then it's most likely a problem of the configure script passing non-prefixed arguments.

That said, I think the patch is wrong.

[Comment 6 Sebastian Luther (few) 2013-12-02 21:03:07 UTC]

Thanks Fabian for your comments. Closing as as NEEDINFO as of comment 4.