Bug 490766 – sys-auth/keystone-2013-2 - init.d script should set --log-file /var/log/keystone

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Davide Rebeccani 2013-11-08 18:08:54 UTC]

After issuing /etc/init.d/keystone start the is no log file in /var/log/keystone because the --log-file option is missing from the .initd file

Reproducible: Always

Steps to Reproduce:
1.emerge =sys-auth/keystone-2013.2
2.stat /var/log/keystone/keystone.log
3.
Actual Results:  
No such file or directory

Expected Results:  
stat reports information about log file

[Comment 1 Davide Rebeccani 2013-11-08 18:10:41 UTC]

Created attachment 362794 [details]
conf.d file with definition of log file path variable

[Comment 2 Davide Rebeccani 2013-11-08 18:11:15 UTC]

Created attachment 362796 [details]
init.d file with --log-file option defined

[Comment 3 Jeroen Roovers (RETIRED) 2013-11-12 14:32:55 UTC]

Comment on attachment 362794 [details]
conf.d file with definition of log file path variable

--- files/keystone.confd        2012-12-09 22:57:11.000000000 +0100
+++ -   2013-11-12 15:32:47.142725383 +0100
@@ -1,2 +1,3 @@
 CONFIG_FILE=/etc/keystone/keystone.conf
+LOG_FILE=/var/log/keystone/keystone.log
 PID_PATH=/var/run/keystone

[Comment 4 Jeroen Roovers (RETIRED) 2013-11-12 14:33:18 UTC]

Comment on attachment 362796 [details]
init.d file with --log-file option defined

--- files/keystone.initd        2013-08-14 16:57:48.714265224 +0200
+++ -   2013-11-12 15:33:10.774507825 +0100
@@ -36,7 +36,8 @@
        ebegin "Starting ${SVCNAME}"
 
        start-stop-daemon --start --quiet --make-pidfile --pidfile "${PID_PATH}/${SVCNAME}.pid" \
-                                         --exec /usr/bin/${SVCNAME}-all --background -- --config-file=${CONFIG_FILE}
+                                         --exec /usr/bin/${SVCNAME}-all --background -- --config-file=${CONFIG_FILE} \
+                                         --log-file=${LOG_FILE}
 
        eend $? "Failed to start ${SVCNAME}"
 }

[Comment 5 Jeroen Roovers (RETIRED) 2013-11-12 14:34:50 UTC]

(In reply to Jeroen Roovers from comment #4)
> Comment on attachment 362796 [details]
> init.d file with --log-file option defined
> 
> --- files/keystone.initd        2013-08-14 16:57:48.714265224 +0200
> +++ -   2013-11-12 15:33:10.774507825 +0100
> @@ -36,7 +36,8 @@
>         ebegin "Starting ${SVCNAME}"
>  
>         start-stop-daemon --start --quiet --make-pidfile --pidfile
> "${PID_PATH}/${SVCNAME}.pid" \
> -                                         --exec /usr/bin/${SVCNAME}-all
> --background -- --config-file=${CONFIG_FILE}
> +                                         --exec /usr/bin/${SVCNAME}-all
> --background -- --config-file=${CONFIG_FILE} \
> +                                         --log-file=${LOG_FILE}
>  
>         eend $? "Failed to start ${SVCNAME}"
>  }

Looks like it could do with fewer tabs, too.

[Comment 6 Matthew Thode ( prometheanfire ) 2013-11-18 03:24:06 UTC]

fixed, thanks :D