mysql-cmake.eclass, mysql-autotools.eclass, mysql.eclass all keep calling mysql_mv_patches() in src_prepare() even if my ebuild contains MY_EXTRAS_VER="none". I would expect src_prepare() to not die() while trying to patch the sources with non-existent patches (when MY_EXTRAS_VER="none"). I am not interested in applying any * ERROR: dev-db/percona-server-5.5.33-r31::my_overlay failed (prepare phase): * No patches directory found! * * Call stack: * ebuild.sh, line 93: Called src_prepare * environment, line 3759: Called mysql-v2_src_prepare * environment, line 3255: Called mysql-cmake_src_prepare * environment, line 2987: Called mysql_mv_patches * environment, line 3378: Called die * The specific snippet of code: * [[ -d "${filesdir}" ]] || die "No patches directory found!";
(chtekk retired, feel free to mark him or remove him as such while you're at it)
I've applied a change to the eclasses in the mysql overlay that should fix this bug. Please sync the overlay and test again.
(In reply to Jorge Manuel B. S. Vicetto from comment #2) > I've applied a change to the eclasses in the mysql overlay that should fix > this bug. Please sync the overlay and test again. tested the updated mysql-cmake.eclass and it worked. thanks. looking at the official portage tree I guess you should also patch mysql.eclass (not sure who uses this one) since it has the same unconditional call to mysql_mv_patches.
(In reply to Petre Rodan from comment #3) > (In reply to Jorge Manuel B. S. Vicetto from comment #2) > > I've applied a change to the eclasses in the mysql overlay that should fix > > this bug. Please sync the overlay and test again. > > tested the updated mysql-cmake.eclass and it worked. thanks. > > looking at the official portage tree I guess you should also patch > mysql.eclass (not sure who uses this one) since it has the same > unconditional call to mysql_mv_patches. The mysql.eclass has been kept for old mysql versions (<5.1.50), that no one should be using anymore - unless they're updating from really old systems to currently supported versions. As such, we only touch it when absolutely required. This change will propagate to the tree when we do the next manual sync from the overlay to the tree.
