Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 490016 - portage-prefix: nosandbox variable not behaving well
Summary: portage-prefix: nosandbox variable not behaving well
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks:
 
Reported: 2013-11-01 02:40 UTC by Benda Xu
Modified: 2013-12-15 16:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-prefix-sandbox.patch (portage-prefix-sandbox.patch,622 bytes, patch)
2013-11-01 02:42 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2013-11-01 02:40:50 UTC
In the prefix branch of portage, nosandbox is always evaluated True.

Patch attached.

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2013-11-01 02:42:17 UTC
Created attachment 362378 [details, diff]
portage-prefix-sandbox.patch
Comment 2 Benda Xu gentoo-dev 2013-11-22 09:16:43 UTC
Fabian, would you please review this patch?
Comment 3 Fabian Groffen gentoo-dev 2013-11-22 12:05:33 UTC
Feels like it makes super sense to me.  I/someone should push this asap.  Benda, feel free to add this to the ebuild for the time being.  (We're tied to gx86 versioning now.)
Comment 4 Fabian Groffen gentoo-dev 2013-11-22 12:06:08 UTC
Prefix should deal with this
Comment 5 Benda Xu gentoo-dev 2013-12-15 03:59:39 UTC
committed without updating changelog.

$ svn diff
Index: portage/portage-2.2.7-r1.ebuild
===================================================================
--- portage/portage-2.2.7-r1.ebuild     (revision 61798)
+++ portage/portage-2.2.7-r1.ebuild     (working copy)
@@ -238,6 +238,7 @@
        use prefix-chaining && epatch "${FILESDIR}"/${PN}-2.2.00.15801-prefix-chaining.patch
        epatch "${FILESDIR}"/${PN}-2.2.7-ebuildshell.patch # 155161
        epatch "${FILESDIR}"/${PN}-2.2.7-shebang-fixes.patch # already in git
+       epatch "${FILESDIR}"/${PN}-2.2.7-sandbox.patch # 490016
 
        if ! use ipc ; then
                einfo "Disabling ipc..."
Comment 6 Fabian Groffen gentoo-dev 2013-12-15 07:23:23 UTC
... and the manifest, why?  (fixing now)
Comment 7 Fabian Groffen gentoo-dev 2013-12-15 07:57:12 UTC
In git, and patched in tree
Comment 8 Benda Xu gentoo-dev 2013-12-15 16:35:15 UTC
(In reply to Fabian Groffen from comment #6)
> ... and the manifest, why?  (fixing now)

Sorry. my fault.