Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489974 - app-misc/gourmet-0.16.1 -- cannot add pictures
Summary: app-misc/gourmet-0.16.1 -- cannot add pictures
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Joe Sapp (RETIRED)
URL: https://github.com/thinkle/gourmet/is...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-10-31 14:34 UTC by m0par
Modified: 2014-02-09 17:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
workaround for when USER_DIRECTORY_PICTURES == None (gourmet-0.16-add.picture.patch,645 bytes, patch)
2013-10-31 14:34 UTC, m0par
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description m0par 2013-10-31 14:34:13 UTC
Created attachment 362362 [details, diff]
workaround for when USER_DIRECTORY_PICTURES == None

For whatever reason, get_user_special_dir(USER_DIRECTORY_PICTURES) returns None.

This results in being unable to add a picture, with the error:

self.fsd.set_current_folder(get_user_special_dir(USER_DIRECTORY_PICTURES))
TypeError: Gtk.FileChooser.set_current_folder() argument 1 must be string, not None

Possibly a bug elsewhere in glib or xdg. I don't know how to trace the problem further. It apparently also happens on Arch Linux as well.

Regardless, gourmet upstream worked around it with a small patch.
https://github.com/thinkle/gourmet/issues/725

With the historically slow release cycle from the gourmet developers, it would be nice if the patch could be included in an updated ebuild.
Comment 1 m0par 2013-10-31 14:47:13 UTC
BTW, this may only be an issue when running an oddball window manager without a gnome/kde desktop environment. e.g. I'm just running WindowMaker.
Comment 2 Joe Sapp (RETIRED) gentoo-dev 2014-01-03 03:01:02 UTC
Is this still an issue with 0.16-r2?  I wouldn't be opposed to adding another patch to the ebuild.
Comment 3 m0par 2014-01-03 03:28:26 UTC
(In reply to Joe Sapp from comment #2)
> Is this still an issue with 0.16-r2?  I wouldn't be opposed to adding
> another patch to the ebuild.

It is still an issue here, and using the patch still fixes that error.

I'm getting a different error now: "No module named PngImagePlugin" (A PIL/pillow issue I suppose. No time to look into it right now--heading to work.) but adding a jpg in gourmet-0.16.1-r2 does work with the patch.
Comment 4 Joe Sapp (RETIRED) gentoo-dev 2014-01-29 21:49:55 UTC
(In reply to m0par from comment #3)
> (In reply to Joe Sapp from comment #2)
> > Is this still an issue with 0.16-r2?  I wouldn't be opposed to adding
> > another patch to the ebuild.
> 
> It is still an issue here, and using the patch still fixes that error.
> 
> I'm getting a different error now: "No module named PngImagePlugin" (A
> PIL/pillow issue I suppose. No time to look into it right now--heading to
> work.) but adding a jpg in gourmet-0.16.1-r2 does work with the patch.

Ok, I'll be bumping the revision soon.  If there's another issue with with PngImagePlugin, please file another bug.  That issue should be taken care of with -r2, but maybe I messed up somewhere.
Comment 5 Joe Sapp (RETIRED) gentoo-dev 2014-02-09 17:29:55 UTC
In CVS now.  Thanks for reporting.