Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489644 - app-shells/fish-2.1.0 version bump
Summary: app-shells/fish-2.1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Jeff (JD) Horelick (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 488518
  Show dependency tree
 
Reported: 2013-10-28 09:20 UTC by Elis Axelsson
Modified: 2013-10-31 02:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for fish 2.1.0 (fish-2.1.0.ebuild,1.08 KB, text/plain)
2013-10-28 09:25 UTC, Elis Axelsson
Details
Patch that fixes the docdir bug (fish-2.1.0-respect-docdir.patch,1.42 KB, patch)
2013-10-28 17:13 UTC, Elis Axelsson
Details | Diff
diff -u of my new ebuild for fish (fish-2.1.0.ebuild.patch,907 bytes, patch)
2013-10-28 17:14 UTC, Elis Axelsson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elis Axelsson 2013-10-28 09:20:00 UTC
fish-2.1.0 was just released, please bump. I made minor adjustments to the ebuild to make it work as expected.

Reproducible: Always
Comment 1 Elis Axelsson 2013-10-28 09:25:21 UTC
Created attachment 362116 [details]
Ebuild for fish 2.1.0

I been using it on the testing version of fish 2.1.0 and it seems to be fine.

Changes I made was to remove the part where we specified docdir to econf to be /usr/share/doc/fish-2.1.0/ since several fish-scripts/functions expects the docs to be in /usr/share/doc/fish/ (for example the function "help"). This should be considered as a bug in fish. But the same bug was there in the 2.0.0 release.

I also removed the declaration of $S, since it seems to not be needed for this release.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-10-28 09:53:04 UTC
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for us.

Gentoo policy says that a package must install its docs into /usr/share/doc/packagename-fullversion/
So removing this from the ebuild is the wrong approach. Rather fix the scripts which don't respect the docdir variable.
Comment 3 Elis Axelsson 2013-10-28 11:05:38 UTC
Linked this issue on fish-irc, and the devs noticed the docdir part and reported it themselfs: https://github.com/fish-shell/fish-shell/issues/1065

It won't be fixed before 2.2.0, but I could backport it when they patch it. I will also submit a diff -u when I got a patch for this issue.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-10-28 11:42:09 UTC
(In reply to Elis Axelsson from comment #3)
> Linked this issue on fish-irc, and the devs noticed the docdir part and
> reported it themselfs: https://github.com/fish-shell/fish-shell/issues/1065
> 
> It won't be fixed before 2.2.0, but I could backport it when they patch it.
> I will also submit a diff -u when I got a patch for this issue.

Thank you for reporting this issue upstream. :)
Comment 5 Elis Axelsson 2013-10-28 17:13:51 UTC
Created attachment 362154 [details, diff]
Patch that fixes the docdir bug

These changes was commited upstream earlier today, they fix the docdir bug.
Comment 6 Elis Axelsson 2013-10-28 17:14:51 UTC
Created attachment 362156 [details, diff]
diff -u of my new ebuild for fish

Added the usage of the patch submited in previous comment.