Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 48962 - webapp_configfile 'd files are installed as symlinks instead of copied
Summary: webapp_configfile 'd files are installed as symlinks instead of copied
Status: VERIFIED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-25 12:25 UTC by Jeremy Huddleston (RETIRED)
Modified: 2004-04-30 12:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
squirrelmail-1.4.2-r4.ebuild (squirrelmail-1.4.2-r4.ebuild,5.14 KB, text/plain)
2004-04-25 12:26 UTC, Jeremy Huddleston (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-25 12:25:38 UTC
I have the latest webapp eclass from cvs and webapp-config-1.4

I was webapp-izing squirrelmail, and I ran into this problem.  here's a snippet from the emerge:
>>> Install squirrelmail-1.4.2-r4 into /var/tmp/portage/squirrelmail-1.4.2-r4/image/ category net-mail
virus-scan
crypt
ssl
 * Installing squirrelmail files.
crypt
ssl
 * (config) /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/config.php
 * (config) /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/config_local.php
 * (config) /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/plugins/retrieveuserdata/config.php
 * (config) /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/plugins/gpg/gpg_local_prefs.txt

Great, so the eclass is getting told that config/config*.php are config files... but webapp-config --install doesn't seem to honor that:

(12:18:17 Sun Apr 25 2004 root@eradicator)
/var/www/localhost/htdocs/squirrelmail $ webapp-config --install squirrelmail 1.4.2-r4

 * Running with these settings:
 *   --force-virtual is OFF
 *   --virtual-dirs  is virtual
 *   --virtual-files is virtual
 *   --user          is root
 *   --group         is root
 *   --hostname      is eradicator.outersquare.org
 *   --server        is apache-basic
 *   --directory     is /var/www/localhost/htdocs/squirrelmail
 *   package         is squirrelmail
 *   version         is 1.4.2-r4
 *   action          is install

 * Do we have squirrelmail-1.4.2-r4 available?
 *   Yes, we do
 * Is there already a package installed in /var/www/localhost/htdocs/squirrelmail?
 * Checking that the username:group 'root:root' is valid
 * Checking specific requirements for apache-basic
 * Installing squirrelmail 1.4.2-r4 ...
 *   Creating required directories
 *     /var/www/localhost/htdocs/squirrelmail/. already exists as a real directory;
 *       skipping /var/www/localhost/htdocs/squirrelmail/.
>>> dir  po
>>> dir  doc
>>> dir  doc/ReleaseNotes
...
>>> sym  config/conf.pl
>>> sym  config/config.php
>>> sym  config/index.php
>>> sym  config/config_local.php
...

/var/www/localhost/htdocs/squirrelmail $ ls -l config
total 2
lrwxrwxrwx    1 root     root           62 Apr 25 12:19 conf.pl -> /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/conf.pl
lrwxrwxrwx    1 root     root           65 Apr 25 12:19 config.php -> /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/config.php
lrwxrwxrwx    1 root     root           71 Apr 25 12:19 config_local.php -> /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/config_local.php
lrwxrwxrwx    1 root     root           64 Apr 25 12:19 index.php -> /usr/share/webapps/squirrelmail/1.4.2-r4/htdocs/config/index.php

Shouldn't these be copied since they are per-vhost config files?
Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-25 12:26:25 UTC
Created attachment 30034 [details]
squirrelmail-1.4.2-r4.ebuild

here's the ebuild
Comment 2 Stuart Herbert (RETIRED) gentoo-dev 2004-04-28 16:08:53 UTC
Hiya,

I'll take a look at it, and see what I need to fix.  In the meantime, webapp-config-1.5 is now out.  I doubt there's anything in there that fixes this bug, but you never know ;-)

Best regards,
Stu
Comment 3 Stuart Herbert (RETIRED) gentoo-dev 2004-04-30 01:27:44 UTC
Fix is in Portage.  Make sure you have webapp.eclass v1.13, and webapp-config-1.6.

Best regards,
Stu
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-30 03:02:28 UTC
Looks fine except for one very bad thing:  --directory defaults to / instead of .

That put everything in my root!

 * Running with these settings:
 *   --force-virtual is OFF
 *   --virtual-dirs  is virtual
 *   --virtual-files is virtual
 *   --user          is root
 *   --group         is root
 *   --hostname      is localhost
 *   --server        is apache-basic
 *   --directory     is /
 *   package         is squirrelmail
 *   version         is 1.4.2-r5
 *   action          is install
Comment 5 Stuart Herbert (RETIRED) gentoo-dev 2004-04-30 10:49:22 UTC
Instead of blindly upgrading, try reading the CHANGES.txt file ;-)  And checking the man page!

The -d <dir> is now a directory relative to your htdocs dir.  So, it's important that you start using the -h <host> switch to tell it which vhost you are installing into.  If you did your etc-update correctly, <host> defaults to 'localhost' all the time now.

Please - open new bugs in Bugzilla about new problems.  It's easier to point people at bugs when the bugzilla report is only about the one problem ;-)

Best regards,
Stu
Comment 6 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-30 12:53:32 UTC
looks good.