Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489368 - sys-apps/openrc bootmisc needs a checkpath -W RC_LIBEXECDIR check
Summary: sys-apps/openrc bootmisc needs a checkpath -W RC_LIBEXECDIR check
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: OpenRC (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 481182
  Show dependency tree
 
Reported: 2013-10-25 12:52 UTC by Duncan
Modified: 2014-01-15 17:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2013-10-25 12:52:41 UTC
Some months ago I finally setup a read-only-by-default root filesystem.  Now bootmisc always warns when it tries to remove RC_LIBEXECDIR/console/* files.

After grepping RC_LIBEXECDIR in /etc/init.d/* (and working around the lack of documentation for RC_LIBEXECDIR and checkpath, bugs 489344 and 489356), it seems that most initscripts are either referencing it for a source (read not write) or if they're writing to it, the write is guarded by a checkpath -W conditional.

Of the scripts I have installed, only bootmisc appears to attempt a write to $RC_LIBEXECDIR unguarded by a writable check such as checkpath -W:

bootmisc line 151: rm -rf "$RC_LIBEXECDIR"/console/*

Thanks for your work on openrc. =:^)

Duncan
Comment 1 Duncan 2014-01-08 20:45:39 UTC
Apology if this is a nuisance and I don't normally do this but bump?  Not even a comment since originally filed over two months ago?  That is uncharacteristic for my openrc bugs (normally at least a comment, thanks) and the two openrc documentation bugs (#489344 and #489356) I opened the same day were quickly commented and one already fixed, so I'm wondering if this one really did just fall thru the cracks, in which case a bump may be warranted.

Consolefont, keymaps and termencoding, which write $RC_LIBEXECDIR/console/* in the first place, already use a checkpath -W "$RC_LIBEXECDIR" conditional, and bootmisc already uses a checkpath -W conditional for other things, but not for its attempt to remove the $RC_LIBEXECDIR/console/* files written by the scripts above that already do the check, so I thought adding the check here would be a a trivial no-brainer, but two and a half months without even a comment?  /Did/ it fall thru the cracks?
Comment 2 William Hubbs gentoo-dev 2014-01-13 00:59:04 UTC
Duncan,

thanks for pinging this bug.

No, this hasn't fallen through the cracks, I just haven't had anything to say about it. Your fix is probably what I'll implement.

The best answer I can give you is it will get fixed when I get to it.

Thanks,

William
Comment 3 William Hubbs gentoo-dev 2014-01-15 17:02:16 UTC
This is fixed in commit 561b53e and will be included in OpenRC-0.13.