Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488542 - app-office/libreoffice - Fix compilation against dev-util/mdds-0.9.0
Summary: app-office/libreoffice - Fix compilation against dev-util/mdds-0.9.0
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-10-19 05:20 UTC by timemars
Modified: 2013-10-21 22:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mtvelements-mdds-0.9.0.patch (mtvelements-mdds-0.9.0.patch,1.22 KB, patch)
2013-10-19 05:20 UTC, timemars
Details | Diff
patched ebuild (libreoffice-4.1.2.3.ebuild,17.02 KB, text/plain)
2013-10-19 05:21 UTC, timemars
Details

Note You need to log in before you can comment on or make changes to this bug.
Description timemars 2013-10-19 05:20:03 UTC
Created attachment 361280 [details, diff]
mtvelements-mdds-0.9.0.patch

Well, it is a patch I found in bug 474710 comment #13. I have been testing it since then, and compilation succeeded every time. The original post is marked FIXED, yet the patch is not included in the ebuild. Hence I open this bug report and hope that it would be pulled in the next version bump.
Comment 1 timemars 2013-10-19 05:21:29 UTC
Created attachment 361282 [details]
patched ebuild

And this is the ebuild I use.
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-19 08:08:43 UTC
Is the patch backward compatible? Does it still allow the old version of the dependency to lead to a successful compilation?
Comment 3 timemars 2013-10-19 11:13:46 UTC
(In reply to Tom Wijsman (TomWij) from comment #2)
> Is the patch backward compatible? Does it still allow the old version of the
> dependency to lead to a successful compilation?

If you are asking whether the patch can be applied to old versions of libreoffice, I think the answer is yes.

Firstly, since the bug was introduced in the 4.1 series, and in the 4.0 series the version of mdds is restricted to < 0.8.0, there's no need to consider the compatibility with 4.0 series.

Here are the release dates of the 4.1 series libreoffice I find in ChangeLog:
libreoffice-4.1.0.1 (23 Jun 2013)
libreoffice-4.1.0.2 (11 Jul 2013)
libreoffice-4.1.0.4 (25 Jul 2013)
libreoffice-4.1.1.2 (30 Aug 2013
libreoffice-4.1.2.2 (23 Sep 2013)
libreoffice-4.1.2.3 (04 Oct 2013)

And emerge log of mine:
$ qlop -gt libreoffice
libreoffice: Sat Aug  3 03:04:04 2013: 12527u seconds
libreoffice: Sun Sep  1 10:39:14 2013: 11882u seconds
libreoffice: Tue Oct 15 00:54:06 2013: 7961u seconds

Sorry for the absence of emerge log before Aug 3 as I cleared it before a emerge -e world on Aug 3.

The patch was released on Jul 20, and according to bug 474710 comment #14 I posted on Jul 21, the patch worked on libreoffice-4.1.0.2.

Then on Aug 3, I made a emerge -e world successfully and the version of libreoffice should be 4.1.0.4

And I compiled libreoffice on Sep 1 without any failure. The version should be 4.1.1.2.

I missed version 4.1.2.2 because I was not available at that time, but libreoffice-4.1.2.3 compiled successfully on Oct 15, so I think there should not be any problem if the patch applied to libreoffice-4.1.2.2(-r1). I will confirm that if necessary.
Comment 4 Jouni Kosonen 2013-10-19 13:12:28 UTC
(In reply to timemars from comment #3)
> (In reply to Tom Wijsman (TomWij) from comment #2)
> > Is the patch backward compatible? Does it still allow the old version of the
> > dependency to lead to a successful compilation?
> 
> If you are asking whether the patch can be applied to old versions of
> libreoffice, I think the answer is yes.

On the other hand, and what I think TomWij was asking, the patch will not allow compilation against dev-util/mdds-0.8.1 because the added const conflicts there.

On the gripping hand, it's likely that support for mdds-0.9.x will be in the next upstream version bump without patching, given that they seem to be bumping the internal copy to either 0.9.0 or 0.9.1.

In fact, the latest upstream bundle (Oct 13, corresponding to 4.1.3.1 AFAICT ) already depends on mdds >= 0.9.0 when using system mdds.
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2013-10-21 22:17:33 UTC
Thanks but afaik not going to happen... we follow the versions that are used in the upstream bundle, to avoid unforeseen interactions...