Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488318 - media-video/mpv[luajit] keyword request
Summary: media-video/mpv[luajit] keyword request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2013-10-17 02:12 UTC by Patrick Lauer
Modified: 2016-08-11 11:32 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2013-10-17 02:12:39 UTC
dependency.bad                2
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~hppa(default/linux/hppa/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~hppa(default/linux/hppa/13.0) ['dev-lang/luajit:2']
Comment 1 Nikoli 2013-10-17 02:32:41 UTC
Please keyword luajit package or mask USE flag.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-17 13:52:49 UTC
Who managed to get this atrocity committed?

RepoMan scours the neighborhood...
  dependency.bad                60
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~arm(default/linux/arm/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~hppa(default/linux/hppa/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~hppa(default/linux/hppa/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/13.0/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/gnome) ['dev-lang/luajit:2'] 
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/desktop/kde) ['dev-lang/luajit:2']  
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc64/13.0/32bit-userland/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/gnome/systemd) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/kde) ['dev-lang/luajit:2'] 
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/13.0/64bit-userland/developer) ['dev-lang/luajit:2']  
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~sparc(default/linux/sparc/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~sparc(default/linux/sparc/13.0) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~sparc(default/linux/sparc/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~sparc(default/linux/sparc/13.0/desktop) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~sparc(default/linux/sparc/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~sparc(default/linux/sparc/13.0/desktop/gnome) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~sparc(default/linux/sparc/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~sparc(default/linux/sparc/13.0/desktop/kde) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: DEPEND: ~sparc(default/linux/sparc/13.0/developer) ['dev-lang/luajit:2']
   media-video/mpv/mpv-0.2.0.ebuild: RDEPEND: ~sparc(default/linux/sparc/13.0/developer) ['dev-lang/luajit:2']
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-17 13:56:09 UTC
  16 Oct 2013; Tom Wijsman <TomWij@gentoo.org> package.use.mask:
  Mask luajit on ~media-video/mpv-0.2.0 because it only has amd64 x86 keywords.

O, I see.

You're supposed to give arch teams the choice. You're also supposed to notify arch teams. You're certainly not supposed to break the tree.
Comment 4 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-17 19:28:40 UTC
(In reply to Jeroen Roovers from comment #3)
>   16 Oct 2013; Tom Wijsman <TomWij@gentoo.org> package.use.mask:
>   Mask luajit on ~media-video/mpv-0.2.0 because it only has amd64 x86
> keywords.
> 
> O, I see.
> 
> You're supposed to give arch teams the choice. You're also supposed to
> notify arch teams. You're certainly not supposed to break the tree.

The Portage tree is not broken, you just forgot to `cvs up`; as for notifying arch teams, where is that explicitly documented other than the hppa comment?

(Though Patrick was first, Nikoli planned to file a bug for hppa in specific.)
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-18 13:13:12 UTC
(In reply to Tom Wijsman (TomWij) from comment #4)
> The Portage tree is not broken, you just forgot to `cvs up`;

No, you broke it for HPPA users and for devs working on mpv. That is what this bug report is all about.

> as for notifying arch teams, where is that explicitly documented other than the hppa comment?

" - Keywording on Upgrades - 
        Sometimes you may need to remove a keyword because of new unresolved
        dependencies. If you do this, you *must* file a bug notifying the
        relevant arch teams."[1]

> (Though Patrick was first, Nikoli planned to file a bug for hppa in
> specific.)

*After* you broke the tree.


[1] http://devmanual.gentoo.org/keywording/index.html (with original emphasis)
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-18 13:37:24 UTC
HPPA keywording dropped.
Comment 7 Nikoli 2013-10-18 15:55:33 UTC
But why you removed keyword for mpv instead of masking one USE flag?
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-18 16:13:26 UTC
(In reply to Nikoli from comment #7)
> But why you removed keyword for mpv instead of masking one USE flag?

No HPPA user ever requested the keyword. I have no build logs of mpv so I positively never tested it. I have no idea why it was keyworded for HPPA in the first place. There are plenty of alternative media players that are keyworded for HPPA. So removal is the obvious choice here.
Comment 9 Nikoli 2013-10-18 16:24:48 UTC
mpv is fork of mplayer and mplayer2, so i just kept all keywords from them. But it seems i should open rekeyword request: during latest month a lot changes were done to codebase, so better to recheck.
Comment 10 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-18 18:18:43 UTC
(In reply to Jeroen Roovers from comment #5)
> No, you broke it for HPPA users and for devs working on mpv.

Yes, HPPA only because of the comment in package.use.mask; no problems for devs.

> Sometimes you may need to remove a keyword because of new unresolved
> dependencies. If you do this, you *must* file a bug notifying the
> relevant arch teams."[1]

For all arches Nikoli planned to do this (#gentoo-desktop; to avoid filing duplicate, I didn't); he delayed this, but this should not form a problem since the temporary masks are in place. It does on HPPA, as I am not permitted to remove the keyword on the USE flag.

> *After* you broke the tree.

The comment literally says to file a bug instead of touching it; so, yes, as a result of what I am requested to do by that comment the tree breaks for HPPA.

That's what the file is designed to solve; and as far as I can tell, only HPPA does it different so as I'm new to doing this on the HPPA arch I'm not sure what you want instead. We did plan to do what was intended; so, why is it atrocity?

We should pursue consensus on consistent USE masking on the profile.use.mask [1] thread as two different methods of which one undocumented doesn't make much sense; anyhow, that's outside the scope of this bug.

[1] http://gentoo.2317880.n4.nabble.com/best-way-to-use-profiles-and-package-use-mask-td16465.html
Comment 11 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 03:55:59 UTC
FWIW, as luajit code changes heavily based on the platform/architecture, the luajit maintainer (a.k.a. myself) isn't going to support anything but amd64 and x86, unless some dev who knows how lua{,jit} works want to co-maintain it for some other arch.

arch testing isn't enough to get a keyword added to luajit.

Thanks.
Comment 12 Nikoli 2013-10-20 16:57:38 UTC
Then just mask USE luajit for unsupported arches.
Comment 13 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 17:03:31 UTC
(In reply to Nikoli from comment #12)
> Then just mask USE luajit for unsupported arches.

This is something you/your proxy should do.
Comment 14 Nikoli 2013-10-20 17:12:23 UTC
But profiles/arch/hppa/package.use.mask tells:
# DON'T TOUCH THIS FILE. Instead, file a bug and assign it to <hppa@gentoo.org>.

So it seems we can mask USE flags only for some arches, for other we need to ask arch teams. Is there some list of such arches or I need to read every package.use.mask file in profile/ dir?
Comment 15 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 17:16:32 UTC
(In reply to Nikoli from comment #14)
> But profiles/arch/hppa/package.use.mask tells:
> # DON'T TOUCH THIS FILE. Instead, file a bug and assign it to
> <hppa@gentoo.org>.
> 
> So it seems we can mask USE flags only for some arches, for other we need to
> ask arch teams. Is there some list of such arches or I need to read every
> package.use.mask file in profile/ dir?

Err... You shouldn't even have added the hppa keyword to this package without the consent/testing from some hppa arch team member, and from jer comments here in this bug I can see that they aren't really happy whit the situation. Just remove hppa from KEYWORDS, as it shouldn't be there.

Also, luajit doesn't works on hppa, and I don't think that it will work some day. You guys are just wasting time on this.

[]'s
Comment 16 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-20 17:32:27 UTC
(In reply to Rafael G. Martins from comment #13)
> This is something you/your proxy should do.

This has already happened before this thread was filed.

The arch teams are left to decide if they want to keyword and/or maintain it; I suspect that they don't but I do not want to assume that, but if that's the case then they can close this bug as there is then no work here left to do.

Future individuals who want to see the keyword and (proxy) maintain it can always file a new bug.

(In reply to Rafael G. Martins from comment #15)
> (In reply to Nikoli from comment #14)
> > [...] <hppa@gentoo.org>.
> 
> [...] Just remove hppa from KEYWORDS, as it shouldn't be there.

The keyword has already been removed early in this thread, and I plan to do so myself for any other package that any form of dependency breaks on; another developer committed it that way early in the days (mistakes happen), but we shouldn't be discussing these matters on a bug.
Comment 17 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 18:11:48 UTC
Thanks for the info, Tom.

BTW, looking at their github repo:

https://github.com/mpv-player/mpv/blob/master/DOCS/man/en/changes.rst#general-changes-for-mplayer2-to-mpv

Specifically this part:
"Removal of support for dead platforms"

I'm not saying that any platform is dead, but it seems that most of this keywording buzz is useless.

I think that you guys should be a bit more careful with keywording stuff.

[]'s
Comment 18 Nikoli 2013-10-20 18:27:42 UTC
Rafael, look at http://packages.debian.org/sid/mpv and http://packages.debian.org/jessie/mpv As you can even Debian supports mpv for a lot arches, not only for x86 related.

"Removal of support for dead platforms" means removing support not for hardware, but for software, they removed support for several dead and obsolete operation systems. I asked recently mpv devs about support for different arches, they told that everything working with mplayer, should work with mpv too, they do not expect anything to be broken for other arhes.

P.S. Debian supports luajit not only for amd64 and x86, but also for arm, mips and ppc:
http://packages.debian.org/sid/luajit
So it should be possible to use patches from http://ftp.de.debian.org/debian/pool/main/l/luajit/luajit_2.0.2+dfsg-1.debian.tar.gz for supporting same arches in Gentoo.
Comment 19 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 18:31:58 UTC
(In reply to Nikoli from comment #18)
[...]
> P.S. Debian supports luajit not only for amd64 and x86, but also for arm,
> mips and ppc:
> http://packages.debian.org/sid/luajit
> So it should be possible to use patches from
> http://ftp.de.debian.org/debian/pool/main/l/luajit/luajit_2.0.2+dfsg-1.
> debian.tar.gz for supporting same arches in Gentoo.

No, only a developer willing to co-maintaining luajit with correct hardware in hands and knowledge of how luajit and lua ecosystem works qualifies to add a keyword for it. Blindly add patches from any other distro isn't an option.

Thanks for understanding.
Comment 20 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 18:36:13 UTC
Let's just stop trying to support arches we can test, please. If you don't have the hw to test something, drop the keywords. If there's an active user base for the package on such arch, they will request the keyword, attaching build logs to the bug, etc.

Support something just for the sake of having a keyword added to an ebuild isn't a good practice, IMHO.
Comment 21 Rafael Martins (RETIRED) gentoo-dev 2013-10-20 18:37:50 UTC
(In reply to Rafael G. Martins from comment #20)
> Let's just stop trying to support arches we can test, please. If you don't

"arches we can't test", obviously.
Comment 22 Markus Meier gentoo-dev 2013-11-30 14:14:06 UTC
package.use.mask is fine for arm.
Comment 23 Tobias Klausmann (RETIRED) gentoo-dev 2014-07-03 15:48:34 UTC
(In reply to Markus Meier from comment #22)
> package.use.mask is fine for arm.

Same for Alpha.
Comment 24 Raúl Porcel (RETIRED) gentoo-dev 2014-08-01 09:39:14 UTC
sparc is also happy with the p.use.mask
Comment 25 Jeroen Roovers (RETIRED) gentoo-dev 2015-05-04 03:56:15 UTC
lj_arch.h:331:2: error: #error "No support for PowerPC 64 bit mode"
Comment 26 Coacher 2016-02-29 06:12:51 UTC
luajit is currently keyworded and stabilized on all arches supported by upstream[0], except for mips. mpv is not keyworded on mips as well. USE mask entries are added for other arches. This bug is fixed now. Thanks to everyone.

[0]: http://luajit.org/install.html