Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488256 - net-misc/netifrc - Workaround for rc_parallel=YES in _wait_for_carrier() is causing a broken output
Summary: net-misc/netifrc - Workaround for rc_parallel=YES in _wait_for_carrier() is c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: netifrc (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: netifrc Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 17:10 UTC by Thomas Deutschmann (RETIRED)
Modified: 2016-11-27 23:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot showing the broken output (output-if-rc_parallel-is-enabled.jpg,192.40 KB, image/jpeg)
2013-10-16 17:10 UTC, Thomas Deutschmann (RETIRED)
Details
Patch, see comment #2 (0003-_wait_for_carrier-Workaround-for-output-when-using-r.patch,1.44 KB, patch)
2013-10-16 17:17 UTC, Thomas Deutschmann (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2013-10-16 17:10:44 UTC
Created attachment 361054 [details]
Screenshot showing the broken output

Hi,

when rc_parallel in sys-apps/openrc is enabled, the output from _wait_for_carrier() in net.lo is broken, because _wait_for_carrier() will use einfon.

The attached screenshot should show you what I mean with "broken output".

I'll attach a patch shortly.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2013-10-16 17:17:04 UTC
Created attachment 361056 [details, diff]
Patch, see comment #2

_wait_for_carrier(): Workaround for output when using rc_parallel="YES" is no longer needed

_wait_for_carrier() was using a workaround when rc_parallel is enabled.
This caused the following broken output:

  https://bugs.gentoo.org/attachment.cgi?id=361054

This patch fixes bug 488256 by removing the workaround, because this
workaround isn't needed anymore.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-10-24 22:09:41 UTC
whissi: is this still needed?
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2016-11-27 23:34:36 UTC
This was already accepted and merged: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=902d48c8bd46dd67565371cb5d2c84f91ad30b8e