Bug 488138 – media-sound/umurmur: use readme.gentoo.eclass to not show elog messages every time

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2013-10-15 18:16:11 UTC]

That would apply to:
 * A configuration file has been installed at /etc/umurmur.conf - you may 
 * want to review it. See also
 *    http://code.google.com/p/umurmur/wiki/Configuring02x


I can do the work if you prefer

Thanks

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2013-10-16 12:32:24 UTC]

Would be nice if you could attach an ebuild patch to this bug.

[Comment 2 Pacho Ramos 2013-10-16 19:18:17 UTC]

Do you want this:
        if use polarssl ; then
                elog
                elog "Because you have enabled PolarSSL support, umurmurd will use a"   
                elog "predefined test-certificate and key if none are configured, which"
                elog "is insecure. See http://code.google.com/p/umurmur/wiki/Installing02x#Installing_uMurmur_with_PolarSSL_support"
                elog "for more information on how to create your certificate and key"
        fi


to be shown always or not?

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2013-10-21 07:34:35 UTC]

Sorry for not replying earlier.
I'd say make this be shown always as it's telling about an insecure setup where I tend to be better safe than sorry.

[Comment 4 Pacho Ramos 2013-10-21 17:04:00 UTC]

Created attachment 361546 [details, diff]
1.patch

This would be the patch then

[Comment 5 Julian Ospald 2013-10-23 13:50:16 UTC]

The eclass exports two functions. I am not entirely sure I want to use it.

Something wrong with inlining the relevant bits (as in: the replacing-version check)? I don't see much else that happens there.

[Comment 6 Julian Ospald 2013-10-23 13:51:17 UTC]

but if any1 of you has a strong opinion on this, mine is not strong

[Comment 7 Pacho Ramos 2013-10-23 17:21:48 UTC]

(In reply to Julian Ospald (hasufell) from comment #5)
> The eclass exports two functions. I am not entirely sure I want to use it.

Why? It is for cases when no other eclass is exporting the phases and, that is not the case of this (it has its own phases and they won't get overwritten)

[Comment 8 Julian Ospald 2013-10-23 17:23:41 UTC]

(In reply to Pacho Ramos from comment #7)
> (In reply to Julian Ospald (hasufell) from comment #5)
> > The eclass exports two functions. I am not entirely sure I want to use it.
> 
> Why? It is for cases when no other eclass is exporting the phases and, that
> is not the case of this (it has its own phases and they won't get
> overwritten)

I wasn't referring to actual, but to potential trouble. I'm just paranoid.

[Comment 9 Pacho Ramos 2013-10-26 22:04:12 UTC]

+  26 Oct 2013; Pacho Ramos <[e-mail]> umurmur-0.2.13.ebuild:
+  Use readme.gentoo.eclass to not show elog messages every time (#488138)
+