Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488110 - python_doscript() should support elf
Summary: python_doscript() should support elf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 484416
  Show dependency tree
 
Reported: 2013-10-15 10:43 UTC by Justin Lecher (RETIRED)
Modified: 2014-03-13 08:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
python_doexe() patch (python-doexe.patch,3.79 KB, patch)
2014-03-12 22:10 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2013-10-15 10:43:35 UTC
Current version relies on a shebang. How about supporting elf as well?
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-17 17:14:20 UTC
Are you sure that *actually* python-exec does not support it? The code was designed to be format-agnostic and the tests themselves often use '#!/usr/bin/env true' shebangs... or is this purely about eclass functions?
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2013-10-18 06:57:07 UTC
Sorry wrong title. I meant python_doscript().
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-18 18:37:56 UTC
@Python, how about adding python_doexe for this? I think that would be less confusing and more resilient to mistakes.
Comment 4 Mike Gilbert gentoo-dev 2013-10-18 19:00:21 UTC
That seems reasonable.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-12 21:50:45 UTC
ping to self ;).
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-12 22:10:15 UTC
Created attachment 372524 [details, diff]
python_doexe() patch

I'm sorry that I forgot about it. Could you test this patch?
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2014-03-13 07:43:03 UTC
debug: _python_ln_rel: rel_target = ../lib/python-exec/python-exec2
debug: _python_rewrite_shebang: entering function, parameters: /var/tmp/portage/dev-python/scientificpython-2.9.2/image//
debug: _python_rewrite_shebang: implementation: python2.7
/var/tmp/portage/dev-python/scientificpython-2.9.2/temp/environment: line 932: read: read error: 0: Is a directory
debug: _python_rewrite_shebang: path = /var/tmp/portage/dev-python/scientificpython-2.9.2/image//
debug: _python_rewrite_shebang: shebang = 
 * A file does not seem to have a supported shebang:
 *   file: /var/tmp/portage/dev-python/scientificpython-2.9.2/image//
 *   shebang: 
 * ERROR: dev-python/scientificpython-2.9.2::gentoo failed (install phase):
 *   _python_rewrite_shebang: /var/tmp/portage/dev-python/scientificpython-2.9.2/image// does not seem to have a valid shebang
 *
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-13 08:10:55 UTC
+  13 Mar 2014; Michał Górny <mgorny@gentoo.org> python-utils-r1.eclass:
+  Add python_doexe() and python_newexe() to handle implementation-specific
+  executables without shebangs.