Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486858 - net-dialup/accel-ppp USE=debug should depend on dev-util/valgrind / incorrect use of "CONFIG_" in CONFIG_CHECK
Summary: net-dialup/accel-ppp USE=debug should depend on dev-util/valgrind / incorrect...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Popov
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-10-03 10:02 UTC by Vladimir Pavljuchenkov (SpiderX)
Modified: 2014-06-03 07:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch (accel-ppp-ebuilds.patch,1.01 KB, patch)
2013-10-03 10:03 UTC, Vladimir Pavljuchenkov (SpiderX) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Pavljuchenkov (SpiderX) 2013-10-03 10:02:31 UTC 
1. Missed dev-util/valgrind for USE-flag debug.
2. String "CONFIG_CHECK="~CONFIG_L2TP ~CONFIG_PPPOE ~CONFIG_PPTP"" should be altered to "CONFIG_CHECK="~L2TP ~PPPOE ~PPTP"".

Reproducible: Always
Comment 1 Vladimir Pavljuchenkov (SpiderX) 2013-10-03 10:03:39 UTC 
Created attachment 360018 [details, diff]
patch
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-10-04 13:42:07 UTC 
It's probably better to rename USE=debug to USE=valgrind so that architectures that have no valgrind support will have it masked automatically. Even the upstream build system calls the flag VALGRIND...
Comment 3 Sergey Popov gentoo-dev 2014-06-03 07:36:04 UTC 
+  03 Jun 2014; Sergey Popov <pinkbyte@gentoo.org> accel-ppp-1.7.3.ebuild,
+  accel-ppp-1.7.9999.ebuild, metadata.xml:
+  Split valgrind integration to separate USE flag, fix CONFIG_CHECK, wrt bug
+  #486858. Thanks to SpiderX <spiderx AT spiderx.dp.ua> for discovering this
+  issue

Finally fixed. Sorry for such long delay.