Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486568 - www-apps/novnc-0.4 - does not install files
Summary: www-apps/novnc-0.4 - does not install files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 12:21 UTC by Alon Bar-Lev (RETIRED)
Modified: 2018-01-18 07:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
noVNC-0.4.ebuild (noVNC-0.4.ebuild,542 bytes, text/plain)
2013-09-30 12:21 UTC, Alon Bar-Lev (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev (RETIRED) gentoo-dev 2013-09-30 12:21:46 UTC
Created attachment 359786 [details]
noVNC-0.4.ebuild

>>> Install novnc-0.4 into /var/tmp/portage/www-apps/novnc-0.4/image/ category www-apps
 * QA Notice: dosym target omits basename: '/usr/share/novnc/'
cp: cannot stat ‘*.html’: No such file or directory
cp: cannot stat ‘include/*’: No such file or directory
cp: cannot stat ‘images/*’: No such file or directory
>>> Completed installing novnc-0.4 into /var/tmp/portage/www-apps/novnc-0.4/image/

Result: no files.

BTW: you do not need to install websocket and such these are available at dev-python/websockify.

Attached is an ebuild I once wrong, maybe you can sync.
Comment 1 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-09-30 14:42:24 UTC
ok, merged some of the changes, specified websockify and nova (optional) as deps
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2013-10-04 08:30:21 UTC
Hi,

Some more comments...

1. if nova USE is off there is no need to install services.

2. anyway, the dependency is exactly the opposite... nova should depend on novnc and not novnc on nova. novnc is generic component has nothing to do with nova... just like any other library.

So these should be removed:
        nova? ( sys-cluster/nova )"


    newconfd "${FILESDIR}/noVNC.confd" noVNC
    newinitd "${FILESDIR}/noVNC.initd" noVNC

    diropts -m 0750
    dodir /var/log/noVNC

And may be added to nova ebuild or you can have nova-novnc ebuild to have only dependency and service, but it is really belongs to nova.

3. nova novnc service should be renamed to nova-novnc as it is nova specific.

4. /opt/noVNC/utils/nova-novncproxy is not acceptable namespace for gentoo, anyway if all moved to nova, and this is where that ebuild installs files, then it is not related to this one.

5. Regardless, service can be written using newer method:
---
#!/sbin/runscript

pidfile="/var/run/${SVCNAME}.pid"
command="/opt/noVNC/utils/nova-novncproxy"
command_args="--flagfile=${FLAG_FILE} --cert=${CERT_FILE} --web ${WEB_ROOT}"
command_background="yes"
start_stop_daemon_args="--stdout ${LOG_PATH}/${SVCNAME}.log --stderr ${LOG_PATH}/${SVCNAME}.err"

depend() {
        need net
}
---

the checkconfig is useless in this regard, no reason to test its existence if not checking its content. But... it can be at start_pre.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2013-10-18 19:16:42 UTC
ping?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2013-10-24 12:32:37 UTC
OK, I applied temp workaround to this ebuild until you free to separate the openstack out.

    if use nova; then
        newconfd "${FILESDIR}/noVNC.confd" noVNC
        newinitd "${FILESDIR}/noVNC.initd" noVNC

        diropts -m 0750
        dodir /var/log/noVNC
    fi
Comment 5 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-10-29 06:54:37 UTC
1. Since the init scripts are for a novnc service I feel that this is the correct package to install it.  Hiding it behind a nova use flag makes sense.

2. Nova does depend on novnc (conditionally).

3. ya, I'm renaming the init scripts/conf.d stuff

4. I was forgetting to install the file too.  Now installing into /usr/bin/

5. new init script, kept the check in start_pre