Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486508 - mail-client/mutt-1.5.21-r13 - Missing include added by mutt-1.5.21-gentoo-patches-r16/04-xterm-titles.patch
Summary: mail-client/mutt-1.5.21-r13 - Missing include added by mutt-1.5.21-gentoo-pat...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2013-09-29 20:03 UTC by Vincent Brillault
Modified: 2014-03-09 11:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Brillault 2013-09-29 20:03:26 UTC
04-xterm-titles.patch adds a new function "mutt_ts_capability" in curs_main.c, declared in mutt_menu.h and used in main.c. However, main.c does not includes mutt_menu.h, resulting in the following QA:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * main.c:781:3: warning: implicit declaration of function ‘mutt_ts_capability’ [-Wimplicit-function-declaration]

Simply adding the missing include fixes the issue:
--- a/main.c    2013-09-29 22:00:30.188483282 +0200
+++ b/main.c    2013-09-29 22:00:30.189483212 +0200
@@ -31,6 +31,7 @@
 #include "url.h"
 #include "mutt_crypt.h"
 #include "mutt_idna.h"
+#include "mutt_menu.h"

 #ifdef USE_SASL
 #include "mutt_sasl.h"
Comment 1 Fabian Groffen gentoo-dev 2013-09-30 19:39:28 UTC
thanks!
Comment 2 Fabian Groffen gentoo-dev 2014-03-09 11:52:00 UTC
This should be in mutt-1.5.22-r2