Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 48646 - madplay-0.15.2b bump
Summary: madplay-0.15.2b bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-21 20:23 UTC by Eric Brown
Modified: 2004-04-22 11:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the new ebuild (madplay-0.15.2b.ebuild,1.16 KB, text/plain)
2004-04-21 20:25 UTC, Eric Brown
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Brown 2004-04-21 20:23:50 UTC
new version of madplay, libmad and libid3tag are still 0.15.1b, but they seem to work together.  i tried adding USE=alsa and USE=esd, but those seem to break it, so that's not included.  had to change the depends to let it work with those non-matching versions.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Eric Brown 2004-04-21 20:25:17 UTC
Created attachment 29797 [details]
the new ebuild
Comment 2 Ciaran McCreesh 2004-04-21 20:41:04 UTC
	use debug && myconf="${myconf} --enable-debugging" \
		|| myconf="${myconf} --disable-debugging"

	use nls || myconf="${myconf} --disable-nls"

What's wrong with use_enable?
Comment 3 Eric Brown 2004-04-21 22:14:54 UTC
i'm not sure, but i was guessing the previous authors did that for a reason :\

also, it's my first ebuild so i'm shy :D
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-21 22:37:55 UTC
thanks... I'll take a look at this in a few =)
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-21 23:01:02 UTC
hmm... is this even needed?  I thought lame fixed itself in the 3.96 release...

can you verify that you need this version.
Comment 6 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-21 23:06:31 UTC
ok, it's late forgive me... it doesn't matter what version of lame is in portage... other people could've used it, so I guess this hack is valid, but I'd like to patch it to not do the gain correction if 3.96 works.  can you verify for me that 3.96 still makes "broken" files...
Comment 7 Eric Brown 2004-04-22 10:07:16 UTC
the what?  the only think i noticed this ebuild has is --with-accuracy (rather than like --with-speed).. so it should be the same as all previous ebuilds of madplay right?
Comment 8 Jeremy Huddleston (RETIRED) gentoo-dev 2004-04-22 10:14:37 UTC
look at the Changelog upstream.  it just does some audio level adjustment on mp3s that were encoded with lame >=3.95.1
Comment 9 Eric Brown 2004-04-22 11:00:41 UTC
From what I can tell, Lame is still using the 89dB gain level, so madplay will correct that (because madplay wanted 83dB for replay gaim).  The 89dB replay gain is mentioned in man lame, and in the changelog.  There is no mention of them going back to 83dB though.

They did add some options to disable replay gain in 3.96 though.  So I think it's safe to assume that if you use any of the replay gain options in Lame 3.96, they will still be "broken".

I don't know if it's possible to verify this on a more technical level though...