Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486110 - media-gfx/aaphoto - Automatic color correction and resizing of photos
Summary: media-gfx/aaphoto - Automatic color correction and resizing of photos
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Ferenc Erki
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2013-09-26 19:11 UTC by Ferenc Erki
Modified: 2013-11-07 10:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
aaphoto-0.42.ebuild (aaphoto-0.42.ebuild,579 bytes, text/plain)
2013-09-26 19:12 UTC, Ferenc Erki
Details
metadata.xml (metadata.xml,234 bytes, text/xml)
2013-09-26 19:12 UTC, Ferenc Erki
Details
aaphoto-0.43.ebuild (aaphoto-0.43.ebuild,591 bytes, text/plain)
2013-10-01 10:00 UTC, Ferenc Erki
Details
aaphoto-0.43.1.ebuild (aaphoto-0.43.1.ebuild,591 bytes, text/plain)
2013-10-05 19:54 UTC, Ferenc Erki
Details
aaphoto-0.43.1.ebuild (aaphoto-0.43.1.ebuild,615 bytes, text/plain)
2013-10-29 17:28 UTC, Ferenc Erki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ferenc Erki 2013-09-26 19:11:21 UTC
"Auto Adjust Photo is a tiny command-line image manipulation tool for automatic 
color correction of photos. It tries to make the picture look better. The 
program does this by analyzing the input image and then sets the most optimal 
contrast, gamma, color balance and saturation for it."

I would also like to volunteer to be a proxied maintainer for the package.

Please review the proposed ebuild and let me know if it needs further modifications.

Reproducible: Always
Comment 1 Ferenc Erki 2013-09-26 19:12:13 UTC
Created attachment 359548 [details]
aaphoto-0.42.ebuild
Comment 2 Ferenc Erki 2013-09-26 19:12:31 UTC
Created attachment 359550 [details]
metadata.xml
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-09-26 23:36:40 UTC
Please note that live ebuilds cannot have a non-9999 version and also cannot have keywords, you probably want to convert this into a 9999 version; if you want us to snapshot a specific version then please let us know and we'll host a tarball we extract from their repository, if upstream has releases you will probably want to use those unless there is a specific reason to snapshot.

The Copyright year indicates this is an ebuild from 2005, this makes me wonder if there have been newer versions of the software since; the rest of the ebuild looks quite good, maybe the dependencies could be tightened up a small bit:

Restricting incomptabile versions, introducing SLOTs, checking if they might need more USE flags, checking for missing dependencies, usage of the slot operator for libpng, etc....

If you know how to do, you are welcome to make and/or test these changes; me or another (proxy) maintainer will revise this soon, thank you for filing a bug.

You can read more about the slot operator and sub slots at https://wiki.gentoo.org/wiki/Sub-slots_and_Slot-Operators

Yes, I think you can be a proxied maintainer for this package.
Comment 4 Ferenc Erki 2013-09-27 10:10:54 UTC
Thanks for the review and tips! :)

I hacked together an ebuild for a previous version long ago for personal use, but recently I noticed the project has moved to github and there's a newer version. So I decided to clean up my ebuild and try to make it available for a wider audience. Apparently I missed updating the dates in the header :)

It seemed like there weren't much going on with the project since last year but the upstream maintainer was very friendly and responsive so far in helping with missing files and minor pull requests. So I think it is possible to have an upstream tag and release on github.

If that's not possible for some reason, I'll go with a snapshot - I suppose it basically means I have to create and attach a tar.gz archive to this bug (if not, please point me to the proper documentation/policies about this).

I'll double-check the dependencies too and then attach an updated ebuild.
Comment 5 Ferenc Erki 2013-10-01 10:00:11 UTC
New version of proposed ebuild containing the following changes:
- update ebuild header date
- use new upstream release via GitHub for installation
- add GitHub project page to HOMEPAGE as upstream moves toward it
- tightened dependencies
- add --force-missing automake option
Comment 6 Ferenc Erki 2013-10-01 10:00:38 UTC
Created attachment 359856 [details]
aaphoto-0.43.ebuild
Comment 7 Ferenc Erki 2013-10-05 19:54:15 UTC
aaphoto-0.43.1 has been released by upstream
Comment 8 Ferenc Erki 2013-10-05 19:54:45 UTC
Created attachment 360186 [details]
aaphoto-0.43.1.ebuild
Comment 9 Ferenc Erki 2013-10-14 13:30:12 UTC
I'd like to ask a proxy maintainer to review the modified ebuild and provide feedback on whether it needs any further modifications. Thanks in advance! :)
Comment 10 Ferenc Erki 2013-10-29 17:27:55 UTC
On #gentoo-dev-help mrueg suggested two more changes:
- specify media-libs/libpng slot to depend on
- rename source tarball after download
Comment 11 Ferenc Erki 2013-10-29 17:28:52 UTC
Created attachment 362242 [details]
aaphoto-0.43.1.ebuild
Comment 12 Sergey Popov gentoo-dev 2013-11-07 10:46:12 UTC
+*aaphoto-0.43.1 (07 Nov 2013)
+
+  07 Nov 2013; Sergey Popov <pinkbyte@gentoo.org> +aaphoto-0.43.1.ebuild,
+  +metadata.xml:
+  Initial commit, wrt bug #486110. Package will be maintained by Ferenc Erki
+  <erkiferenc AT gmail.com> through proxy maintainers

I have committed ebuild with some changes and assigned you as maintainer. Enjoy ;-)