Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 485924 - app-admin/hddtemp - systemd service fails
Summary: app-admin/hddtemp - systemd service fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-09-25 06:01 UTC by Tilo Prütz
Modified: 2013-09-28 08:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tilo Prütz 2013-09-25 06:01:19 UTC
The systemd service for app-admin/hddtemp does not work properly. It has to be of type 'forking' and the options environment variable for using /etc/conf.d/hddtemp is wrong, too (HDDTEMP_OPTIONS instead of HDDTEMP_OPTS).

Reproducible: Always




I suggest the change of the service section to:

[Service]
Type=forking
EnvironmentFile=/etc/conf.d/hddtemp
ExecStart=/usr/sbin/hddtemp -d $HDDTEMP_OPTS $HDDTEMP_DRIVES
Comment 1 Amadeusz Żołnowski (RETIRED) gentoo-dev 2013-09-25 19:52:20 UTC
Var names are wrong, indeed. Unless Pacho has some remarks, I'll apply your solution.
Comment 2 Pacho Ramos gentoo-dev 2013-09-25 21:20:07 UTC
This needs a bit more additional work:
1. Try to avoid forking (will need to check hddtemp options for seeing if one let us avoid that)
2. Stop relying on conf.d file (you can see latest ntp ebuild about how it's passing options)

We can take care of it (but, in my case, probably not until Saturday or Sunday)
Comment 3 Amadeusz Żołnowski (RETIRED) gentoo-dev 2013-09-26 08:46:01 UTC
(In reply to Pacho Ramos from comment #2)
> We can take care of it (but, in my case, probably not until Saturday or
> Sunday)

Ok, please take. I am not into that systemd stuff and I am not going to have much time until Saturday, too.
Comment 4 Tilo Prütz 2013-09-27 08:48:46 UTC
Thanks! Time is not pressing here since my patched service works fine :).
BTW: I could not find a switch for suppressing the fork.
Comment 5 Pacho Ramos gentoo-dev 2013-09-28 08:09:09 UTC
+*hddtemp-0.3_beta15-r24 (28 Sep 2013)
+*hddtemp-0.3_beta15-r7 (28 Sep 2013)
+
+  28 Sep 2013; Pacho Ramos <pacho@gentoo.org> +files/hddtemp.service-r1,
+  +files/hddtemp.service.conf, +hddtemp-0.3_beta15-r24.ebuild,
+  +hddtemp-0.3_beta15-r7.ebuild:
+  Fix unit file (#485924 by Tilo Prütz)
+