Bug 485354 – dev-util/mingw64-runtime-3.0.0 - version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alon Bar-Lev (RETIRED) 2013-09-18 23:53:26 UTC]

Created attachment 358962 [details]
mingw64-runtime-3.0.9999.ebuild

Hi,

Today I noticed 3.0 was released, but then reverted after few hours.

Branch exist so we can prepare.

Attached is a live ebuild for the 3.x series, I hope I got it right.

I am attaching full ebuild as there were significant changes.

Working for win32 and win64.

Thanks!

[Comment 1 Alon Bar-Lev (RETIRED) 2013-09-23 18:11:44 UTC]

Released!

[Comment 2 Alon Bar-Lev (RETIRED) 2013-09-23 18:12:17 UTC]

Created attachment 359310 [details]
mingw64-runtime-3.0.0.ebuild

[Comment 3 SpanKY 2013-09-28 22:14:19 UTC]

Comment on attachment 359310 [details]
mingw64-runtime-3.0.0.ebuild

you should really post diffs, not whole files

have you tested bootstrapping from nothing ?  `crossdev -C mingw64 && crossdev mingw64` ...

>KEYWORDS="~x86 ~amd64"
>IUSE="crosscompile_opts_headers-only tools idl"

keep things sorted

>src_configure() {
>	if just_headers; then
>		extra_conf="--without-crt"
>	else
>		extra_conf=" \
>			--with-crt \
>			$(use_with tools) \
>		"
>	fi

declare extra_econf as `local`, and change it to an array

>	case "${CTARGET}" in

drop the quotes

>		x86_64*) extra_conf="${extra_conf} --disable-lib32 --enable-lib64" ;;
>		i686*) extra_conf="${extra_conf} --enable-lib32 --disable-lib64" ;;

i686 misses other x86 targets.  and it should `die` if the target is unknown.

also unindent it so the case statements are the same level as the `case` and `esac`

[Comment 4 Alon Bar-Lev (RETIRED) 2013-09-28 22:17:28 UTC]

(In reply to SpanKY from comment #3)
> Comment on attachment 359310 [details]
> mingw64-runtime-3.0.0.ebuild
> 
> you should really post diffs, not whole files

comment#0... I am attaching full ebuild as there were significant changes.

> 
> have you tested bootstrapping from nothing ?  `crossdev -C mingw64 &&
> crossdev mingw64` ...

yes, will try again.

thanks for the comments.

[Comment 5 Alon Bar-Lev (RETIRED) 2013-09-28 23:00:44 UTC]

Created attachment 359706 [details, diff]
mingw64-runtime-3.0.0.ebuild.diff

Updated ebuild.

diff per on your request.

I hope I addressed all your comments.

Tested using:

crossdev -C -t x86_64-w64-mingw32
crossdev -t x86_64-w64-mingw32

crossdev -C -t i686-w64-mingw32
crossdev -t i686-w64-mingw32

[Comment 6 SpanKY 2013-09-29 01:08:26 UTC]

Comment on attachment 359706 [details, diff]
mingw64-runtime-3.0.0.ebuild.diff

>+	if just_headers; then
>+		extra_conf+=( "--without-crt" )
>+	else
>+		extra_conf+=(
>+			"--with-crt"
>+			"$(use_with tools)"

i would drop the quotes with these flags as they're unnecessary.  it also makes it harder for syntax highlighters do their job.

>+		${extra_conf[@]}

this should have quotes though so it is properly expanded

[Comment 7 Alon Bar-Lev (RETIRED) 2013-09-29 06:28:29 UTC]

Created attachment 359726 [details, diff]
mingw64-runtime-3.0.0.ebuild.diff

Thanks!

Handled quotes.

[Comment 8 SpanKY 2013-09-29 22:22:46 UTC]

(In reply to Alon Bar-Lev from comment #7)

LGTM; feel free to commit

[Comment 9 Alon Bar-Lev (RETIRED) 2013-09-30 08:16:55 UTC]

(In reply to SpanKY from comment #8)
> (In reply to Alon Bar-Lev from comment #7)
> 
> LGTM; feel free to commit

Done.

CC me on every issue.

Thanks!