Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 48484 - unneeded dependencies in kdemultimedia
Summary: unneeded dependencies in kdemultimedia
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-20 10:20 UTC by Gregorio Guidi (RETIRED)
Modified: 2004-04-20 18:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for kdemultimedia-3.2.2.ebuild (kdemultimedia-3.2.2.ebuild.patch,2.64 KB, patch)
2004-04-20 10:20 UTC, Gregorio Guidi (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregorio Guidi (RETIRED) gentoo-dev 2004-04-20 10:20:05 UTC
I suggest to remove from kde-base/kdemultimedia all these dependencies:
sys-libs/ncurses, vitrual/mpg123,media-libs/nas, media-sound/esound,
x11-libs/openmotif, sys-libs/slang, dev-lang/tk, dev-lang/tcl,
dev-libs/glib-2.2.1, x11-libs/gtk+-1.2*, media-libs/id3lib.

vitrual/mpg123:
	I think it was added because there's a module for arts in the
	directory mpg123_artsplugin, but:
	it's not compiled normally, see for instance this snippet from
	configure:
	====================
kde_mpeglib_compiles=no

case "$OS_TYPE" in
  FreeBSD)
    kde_mpeglib_compiles=yes
    ;;
  NetBSD)
    kde_mpeglib_compiles=yes
    ;;
  Linux)
    kde_mpeglib_compiles=yes
    ;;
[........................................]
if test "$kde_mpeglib_compiles" = "yes"
then
DO_NOT_COMPILE="$DO_NOT_COMPILE mpg123_artsplugin"
fi
	==========================
	Moreover, it does not reference an external mpg123, but is in fact
	an internal implementation of the mpg123 backend.

media-libs/id3lib:
	It was not a dep in 3.1, it was brought into 3.2 as a dep for juk,
	but juk now depends only on taglib, and there's no other references
	to id3lib in the code.

sys-libs/ncurses, media-libs/nas, media-sound/esound,
x11-libs/openmotif, sys-libs/slang, dev-lang/tk, dev-lang/tcl,
dev-libs/glib-2.2.1, x11-libs/gtk+-1.2*:
	All these were dependencies of the defunct kmidi (in particular
	of its internal implementation of timidity).
	So they are not needed anymore, and the same holds for the
	--enable-audio and --enable-interface switches.
	you can find a proof that those switches and those deps were just for
	kmidi in the (now removed) kmidi configure.in.in:

http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdemultimedia/kmidi/Attic/configure.in.in

A patch for these changes will follow, where I also added a dep on 
media-libs/flac and added a configure switch for lame.
Comment 1 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-20 10:20:35 UTC
Created attachment 29707 [details, diff]
patch for kdemultimedia-3.2.2.ebuild
Comment 2 Caleb Tennis (RETIRED) gentoo-dev 2004-04-20 18:26:10 UTC
I've been waiting for someone to do this!  Committed, with the notion that if someone complains I'll send then your way :)

Thanks.