Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484786 - sci-geosciences/osgearth-2.4 with dev-lang/v8-3.19.18.19 - /usr/include/v8.h:752:53: error: ‘v8::Persistent& v8::Persistent::operator=(const v8::Persistent&) [with T = v8::Context, v8::Persistent = v8::Persistentv8::Context]’ is private
Summary: sci-geosciences/osgearth-2.4 with dev-lang/v8-3.19.18.19 - /usr/include/v8.h:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 16:00 UTC by Chris Stankevitz
Modified: 2013-11-22 13:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
osgearth-v8.patch (patch,433 bytes, patch)
2013-11-03 01:13 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Stankevitz 2013-09-13 16:00:19 UTC
Upstream bug report here: https://github.com/gwaldron/osgearth/issues/333
Comment 1 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-10-10 19:33:25 UTC
The Gentoo Chromium team is now phasing out dev-lang/v8 shared package. I'm working with v8 upstream to get the library in better shape API and ABI-wise, but the ETA is very long ("years"). Please switch the package to use bundled v8.
Comment 2 Julian Ospald 2013-10-10 19:34:34 UTC
(In reply to Paweł Hajdan, Jr. from comment #1)
> The Gentoo Chromium team is now phasing out dev-lang/v8 shared package. I'm
> working with v8 upstream to get the library in better shape API and
> ABI-wise, but the ETA is very long ("years"). Please switch the package to
> use bundled v8.

wat? There is no bundled v8.
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-10-11 03:17:30 UTC
(In reply to Julian Ospald (hasufell) from comment #2)
> wat? There is no bundled v8.

This either needs to be bundled or (I've noticed this is an optional dependency) just drop it.

Note: talking is easy. Feel free to produce patches to stay on top of latest stable v8 releases. Every 6 weeks.

I actually spend considerable time unbundling what's possible from chromium. I'm sorry some dependencies actually require more effort. I'm working with v8 upstream to improve this, but it'll take a long time before effects become visible (provided it succeeds).
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-11-03 01:13:47 UTC
Created attachment 362458 [details, diff]
osgearth-v8.patch

I'd like to make osgearth ebuild apply the attached patch and pass -DOSGEARTH_USE_V8=OFF to cmake.

It currently fails to build otherwise.
Comment 5 Julian Ospald 2013-11-03 11:46:00 UTC
(In reply to Paweł Hajdan, Jr. from comment #4)
> Created attachment 362458 [details, diff] [details, diff]
> osgearth-v8.patch
> 
> I'd like to make osgearth ebuild apply the attached patch and pass
> -DOSGEARTH_USE_V8=OFF to cmake.
> 
> It currently fails to build otherwise.

and then what? Have a crippled version?

this is what I'm going to do:
a) treeclean
or
b) fix the dep to =dev-lang/v8-3.18.5.14
Comment 6 Julian Ospald 2013-11-03 12:03:01 UTC
+  03 Nov 2013; Julian Ospald <hasufell@gentoo.org> osgearth-2.4.ebuild:
+  fix dev-lang/v8 dep wrt #484786
Comment 7 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-11-03 17:24:06 UTC
(In reply to Julian Ospald (hasufell) from comment #5)
> and then what? Have a crippled version?

You can talk to upstream to bundle v8. I'm really convinced in the current situation this is the only option.

> this is what I'm going to do:
> a) treeclean

Feel free. Isn't it better to at least have non-JS functionality though? I'm not that familiar with osgearth, maybe JS is critical, but from what I've read it's optional.

> b) fix the dep to =dev-lang/v8-3.18.5.14

I've seen you went this way - please note however we (Chromium team) are going to remove old vulnerable v8 versions. Maybe even v8-3.18, I'll need to check the security status.

Also, this is just inviting dependency conflicts, and is exactly the reason for moving away from shared v8 for now. Note that I do work with upstream to improve this, but ETA is very long and it's not certain whether it's going to happen.
Comment 8 Julian Ospald 2013-11-03 17:28:38 UTC
when you remove a library you have to check reverse deps and mask the library you want to remove first

everything else will be resolved then, so I don't understand why you reopen this bug

=foo/bar-12.3 deps are perfectly valid
Comment 9 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-11-03 17:33:11 UTC
(In reply to Julian Ospald (hasufell) from comment #8)
> when you remove a library you have to check reverse deps and mask the
> library you want to remove first

That's correct. dev-lang/v8 actually is very likely to go masked in the coming weeks.

I'd either mask osgearth then or file a bug about either masking it or removing the v8 dep. That's totally fine for me.

> everything else will be resolved then, so I don't understand why you reopen
> this bug
> 
> =foo/bar-12.3 deps are perfectly valid

Agreed. Closing then. If you have further comments (I'm always willing to listen and try to find a solution that would work for you) you're always welcome to either send a direct e-mail to me, or to chromium@ if you prefer.
Comment 10 Julian Ospald 2013-11-22 13:39:00 UTC
mask reverted, v8 support dropped, bumped to 2.5