Bug 48455 – emerging hddtemp 0.3_beta11 fails

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Leander 2004-04-20 05:19:37 UTC]

There's an error with gcc because of a missing include file.

Reproducible: Always
Steps to Reproduce:
1. emerge =hddtemp-0.3_beta11

Actual Results:  
hddtemp.c: Dans la fonction 

[Comment 1 Leander 2004-04-20 05:19:37 UTC]

There's an error with gcc because of a missing include file.

Reproducible: Always
Steps to Reproduce:
1. emerge =hddtemp-0.3_beta11

Actual Results:  
hddtemp.c: Dans la fonction « main »:
hddtemp.c:424: attention : implicit declaration of function `setlocale'
hddtemp.c:424: error: `LC_ALL' undeclared (first use in this function)
hddtemp.c:424: error: (Each undeclared identifier is reported only once
hddtemp.c:424: error: for each function it appears in.)
hddtemp.c:491: attention : comparison between signed and unsigned
make[2]: *** [hddtemp-hddtemp.o] Erreur 1
make[2]: *** Attente des tâches non terminées....
scsicmds.c: Dans la fonction « modeselect »:
scsicmds.c:110: attention : unused parameter `pagenum'
scsicmds.c: Dans la fonction « modesense10 »:
scsicmds.c:149: attention : unused parameter `pagenum'
make[2]: Leaving directory
`/var/tmp/portage/hddtemp-0.3_beta11/work/hddtemp-0.3-beta11/src'
make[1]: *** [all-recursive] Erreur 1
make[1]: Leaving directory
`/var/tmp/portage/hddtemp-0.3_beta11/work/hddtemp-0.3-beta11'
make: *** [all] Erreur 2

!!! ERROR: app-admin/hddtemp-0.3_beta11 failed.
!!! Function src_compile, Line 34, Exitcode 2
!!! (no error message)



I fixed the problem for portage by patching the sources, just a missing #include
<locale.h> in hddtemp.c . But the problem seems to be with portage rather than
the sources, since compiling by hand as both root and user works fine.

emerge info:
Portage 2.0.50-r6 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20040207-r0, 2.6.5)
=================================================================
System uname: 2.6.5 i686 AMD Athlon(TM) XP 2000+
Gentoo Base System version 1.4.9
Autoconf: sys-devel/autoconf-2.58-r1
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache quiet sandbox"
GENTOO_MIRRORS="ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/
ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo/
ftp://ibiblio.org/pub/Linux/distributions/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X acpi alsa apache2 berkdb bonobo cdr cjk dga dvd encode gdbm gpm gtk
gtk2 java ldap mmx motif mpeg ncurses nls nptl oggvorbis opengl quicktime
readline sdl slang sse ssl tcltk truetype x86 xml2 xv zlib"

Locale settings as root and user:
LANG=fr_FR@euro

[Comment 2 Leander 2004-04-20 05:21:29 UTC]

Created attachment 29687 [details]
Modified ebuild to patch the sources

Just added an epatch directive.

[Comment 3 Leander 2004-04-20 05:23:18 UTC]

Created attachment 29688 [details, diff]
Patch for missing #define

Simply adds #define <locale.h> to hddtemp.c to ensure gcc doesn't complain
about the function setlocale()

[Comment 4 Leander 2004-04-20 05:27:26 UTC]

The complete log of emerge is available here:
http://leander256.free.fr/gentoo/bugzilla/emerge_hddtemp.log

[Comment 5 Albert Holm 2004-10-27 01:56:53 UTC]

Still same error with hddtemp-0.3_beta12. 

Proposed solution does not apply: 
PATCH COMMAND:  patch -p0 -g0 < /usr/portage/app-admin/hddtemp/files/hddtemp-0.3_beta12.include-locale.diff

==================================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- src/hddtemp.c2004-04-15 16:18:51.573338128 +0200
|+++ src/hddtemp.c2004-04-15 16:18:45.754222768 +0200
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

repeated for -p0 to -p4.

[Comment 6 Jarno Honkanen 2004-11-13 18:59:45 UTC]

Created attachment 43898 [details, diff]
nls disable patch for hddtemp-0.3_beta12

This patch works me when nls is disabled.

[Comment 7 Michal Januszewski (RETIRED) 2005-07-13 09:35:11 UTC]

Could you please check whether hddtemp-0.3_beta13 works for you?

[Comment 8 Albert Holm 2005-09-07 13:24:20 UTC]

hddtemp-0.3_beta13 works for me, with both USE="nls" and USE="-nls".

[Comment 9 Jakub Moc (RETIRED) 2005-10-01 14:36:20 UTC]

Closing.