484448 – =app-portage/ufed-9999 - missing dependency on dev-perl/Readonly

Bug 484448 - =app-portage/ufed-9999 - missing dependency on dev-perl/Readonly

Summary: =app-portage/ufed-9999 - missing dependency on dev-perl/Readonly

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Tools (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Sven Eden

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-09-10 08:23 UTC by Marcin Mirosław
Modified:	2013-09-11 07:14 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ufed-9999.ebuild (ufed-9999.ebuild,835 bytes, text/plain) 2013-09-10 09:35 UTC, Alice Ferrazzi	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marcin Mirosław 2013-09-10 08:23:12 UTC

# ufed
Can't locate Readonly.pm in @INC (@INC contains: /usr/share/ufed /etc/perl /usr/lib64/perl5/site_perl/5.12.4/x86_64-linux /usr/lib64/perl5/site_perl/5.12.4 /usr/lib64
/perl5/vendor_perl/5.12.4/x86_64-linux /usr/lib64/perl5/vendor_perl/5.12.4 /usr/lib64/perl5/site_perl /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/5.12.4/x86_64-linu
x /usr/lib64/perl5/5.12.4 /usr/local/lib/site_perl .) at /usr/share/ufed/Portage.pm line 9.
BEGIN failed--compilation aborted at /usr/share/ufed/Portage.pm line 9.
Compilation failed in require at /usr/sbin/ufed line 10.
BEGIN failed--compilation aborted at /usr/sbin/ufed line 10.

After I installed dev-perl/Readonly ufed starts without problem.

Comment 1 Alice Ferrazzi Gentoo Infrastructure

2013-09-10 09:35:25 UTC

Created attachment 358404 [details]
ufed-9999.ebuild

tested on freebsd and amd64 

attached ebuild fix

Comment 2 Sven Eden 2013-09-10 12:38:55 UTC

I am afraid I can not change the ebuild, as I am not a gentoo developer.

But it is my fault that this dependency exists, I never realized Readonly was not in the core.

However, as this is only to set a debug flag, I guess I can live with one Perl::Critic warning and have just pushed a change to no longer use Readonly.

No ebuild change needed, at least for 9999.

Comment 3 Marcin Mirosław 2013-09-10 12:50:48 UTC

Thank!

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2013-09-10 13:21:06 UTC

Comment on attachment 358404 [details]
ufed-9999.ebuild

--- ufed-9999.ebuild    2013-04-04 16:40:01.192977286 +0200
+++ -   2013-09-10 15:20:53.919734742 +0200
@@ -19,6 +19,7 @@
 
 COMMON_DEPEND="sys-libs/ncurses"
 RDEPEND="${COMMON_DEPEND}
+       dev-perl/Readonly
        dev-lang/perl"
 DEPEND="${COMMON_DEPEND}
        virtual/pkgconfig"

Comment 5 Sven Eden 2013-09-11 07:14:57 UTC

(In reply to Jeroen Roovers from comment #4)
> Comment on attachment 358404 [details]
> ufed-9999.ebuild
> 
> --- ufed-9999.ebuild    2013-04-04 16:40:01.192977286 +0200
> +++ -   2013-09-10 15:20:53.919734742 +0200
> @@ -19,6 +19,7 @@
>  
>  COMMON_DEPEND="sys-libs/ncurses"
>  RDEPEND="${COMMON_DEPEND}
> +       dev-perl/Readonly
>         dev-lang/perl"
>  DEPEND="${COMMON_DEPEND}
>         virtual/pkgconfig"

Thank you Jeroen, but there is no longer any dependency to dev-perl/Readonly. I have switched back to use the constant pragma, although Perl::Critic pesters me now with it. ;)

I have checked both 0.90_rc versions, neither needs Readonly. (*phew*)