Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484360 - app-emulation/open-vm-tools-2013.04.16.1098359-r1 - add USE="modules pam"
Summary: app-emulation/open-vm-tools-2013.04.16.1098359-r1 - add USE="modules pam"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-09-09 17:13 UTC by David Niblett
Modified: 2014-01-19 19:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild for open-vm-tools (open-vm-tools-2013.04.16.1098359-r1.ebuild,3.02 KB, text/plain)
2013-09-09 17:13 UTC, David Niblett
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Niblett 2013-09-09 17:13:13 UTC
Created attachment 358380 [details]
updated ebuild for open-vm-tools

I just wanted to submit a modified open-vm-tools ebuild.  I prefer to use a monolithic kernel build and the open-vm-tools has always been required to use modules when it can be built without them.

So I've changed the open-vm-tools ebuild to optionally be built with modules and also with pam since that's also an optional item.

I've attached the fixed ebuild for the maintainer to review if they would like to update the ebuild for future version.

Thanks,
David
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-09-10 14:01:35 UTC
Comment on attachment 358380 [details]
updated ebuild for open-vm-tools

--- open-vm-tools-2013.04.16.1098359-r1.ebuild  2013-08-31 08:26:06.000000000 +0200
+++ -   2013-09-10 16:01:24.881352686 +0200
@@ -16,14 +16,14 @@
 LICENSE="LGPL-2"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="X doc fuse icu +pic xinerama"
+IUSE="X doc fuse icu +pic xinerama modules pam"
 
-RDEPEND="app-emulation/open-vm-tools-kmod
+RDEPEND="modules? ( app-emulation/open-vm-tools-kmod )
        dev-libs/glib:2
        dev-libs/libdnet
        sys-apps/ethtool
        sys-process/procps
-       virtual/pam
+       pam? ( virtual/pam )
        X? (
                dev-cpp/gtkmm:2.4
                x11-base/xorg-server
@@ -69,7 +69,7 @@
        econf \
                --with-procps \
                --with-dnet \
-               --without-kernel-modules \
+               $(use_with modules kernel-modules) \
                $(use_enable doc docs) \
                --docdir=/usr/share/doc/${PF} \
                $(use_with X x) \
@@ -77,7 +77,8 @@
                $(use_with X gtkmm) \
                $(use_with icu) \
                $(use_with pic) \
-               $(use_enable xinerama multimon)
+               $(use_enable xinerama multimon) \
+               $(use_with pam)
 
        # Bugs 260878, 326761
        find ./ -name Makefile | xargs sed -i -e 's/-Werror//g'  || die "sed out Werror failed"
Comment 2 Mike Gilbert gentoo-dev 2014-01-19 19:23:19 UTC
Thanks for the suggestions.

+*open-vm-tools-2013.09.16.1328054-r2 (19 Jan 2014)
+
+  19 Jan 2014; Mike Gilbert <floppym@gentoo.org>
+  +open-vm-tools-2013.09.16.1328054-r2.ebuild:
+  Make modules and PAM optional, bug 484360.
+