Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484104 - Outdated suggestion in Autotools basics guide
Summary: Outdated suggestion in Autotools basics guide
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Devmanual Team
URL: https://devmanual.gentoo.org/general-...
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-09-07 13:43 UTC by Michael Orlitzky
Modified: 2013-09-07 19:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated suggestions for EAPI >= 2 (bug484104.patch,1.47 KB, patch)
2013-09-07 14:28 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2013-09-07 13:43:17 UTC
The recommendation here is from EAPI < 2:

  You will see autotools being used variously in both src_unpack and 
  src_compile. The QA people prefer it in src_unpack — the rationale is that 
  src_unpack handles "getting the package ready to be compiled" — but there is 
  no official policy which mandates this.

I believe the appropriate place these days is in src_prepare.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2013-09-07 13:45:18 UTC
Care to submit a patch? :)
Comment 2 Michael Orlitzky gentoo-dev 2013-09-07 14:28:41 UTC
Created attachment 358174 [details, diff]
Updated suggestions for EAPI >= 2

Sure, why not.
Comment 3 Michael Orlitzky gentoo-dev 2013-09-07 14:29:56 UTC
Also, someone should get rid of this:

http://sources.gentoo.org/gitweb/?p=devmanual.git;a=summary
Comment 4 Ulrich Müller gentoo-dev 2013-09-07 14:45:08 UTC
(In reply to Michael Orlitzky from comment #3)
> Also, someone should get rid of this:
> http://sources.gentoo.org/gitweb/?p=devmanual.git;a=summary

See bug 350289.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2013-09-07 18:48:06 UTC
(In reply to Michael Orlitzky from comment #2)
> Created attachment 358174 [details, diff] [details, diff]
> Updated suggestions for EAPI >= 2
> 
> Sure, why not.

Thanks fixed. However, I had troubles applying your patch using 'git am -3'. I am not sure why. I presume you used git-format-patch to generate it correct?
Comment 6 Michael Orlitzky gentoo-dev 2013-09-07 19:23:13 UTC
(In reply to Markos Chandras from comment #5)
> 
> Thanks fixed. However, I had troubles applying your patch using 'git am -3'.
> I am not sure why. I presume you used git-format-patch to generate it
> correct?

No, sorry; I wasn't sure what the protocol was, so I made it `patch -p1` compatible. I'll do it right next time.