Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484036 - systemd.eclass: Add a canonical way to install /etc/systemd/system/foo.service.d/gentoo.org files
Summary: systemd.eclass: Add a canonical way to install /etc/systemd/system/foo.servic...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-09-06 19:01 UTC by Pacho Ramos
Modified: 2013-09-18 21:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
1.patch (1.patch,1.08 KB, patch)
2013-09-07 14:34 UTC, Pacho Ramos
Details | Diff
1.patch (1.patch,1.08 KB, patch)
2013-09-07 19:23 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2013-09-06 19:01:45 UTC
Well, I have commented it sometimes in IRC but haven't had time to report and work on it. Since some packages will need to provide a config file, would be nice to have a systemd.eclass function doing that work to ensure file is installed properly.

I see one problem: how to be sure "foo" is replaced by proper name for the installed unit file.

I see two ways of ensuring that:
- Provide the config-install support in systemd_{do,new}unit functions with an option that would simply catch a file and install it under proper location, taking "foo" from the foo.service name.
- Provide a function for installing this that would force this files to be named in some specific way like "unitname-gentoo.conf". Then, the function could take the name of the dir from there and install it (with newins) as unitname.service.d/gentoo.org

What do you think?

Thanks
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-07 12:47:12 UTC
I'd go for (1). As explicit as possible.
Comment 2 Pacho Ramos gentoo-dev 2013-09-07 14:34:25 UTC
Created attachment 358178 [details, diff]
1.patch

This is a work in progress but still doesn't work. Will need to learn more :S
Comment 3 Pacho Ramos gentoo-dev 2013-09-07 19:23:25 UTC
Created attachment 358204 [details, diff]
1.patch

places shift in better place but still fails
Comment 4 Pacho Ramos gentoo-dev 2013-09-18 21:57:03 UTC
this was fixed some days ago