482768 – leechcraft.eclass (and some packages): unnecessary use of EGIT_PROJECT

Bug 482768 - leechcraft.eclass (and some packages): unnecessary use of EGIT_PROJECT

Summary: leechcraft.eclass (and some packages): unnecessary use of EGIT_PROJECT

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Leechcraft Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	git-2-api-aug2013
	Show dependency tree

Reported:	2013-08-28 08:20 UTC by Michał Górny
Modified:	2013-09-02 11:43 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2013-08-28 08:20:39 UTC

Per eclass docs, the default value is:

    # EGIT_PROJECT="${EGIT_REPO_URI##*/}"

Your eclass does:

    EGIT_REPO_URI="git://github.com/0xd34df00d/leechcraft.git"
    EGIT_PROJECT="leechcraft"

which is almost equivalent (well, leechcraft.git is the correct name). Please drop the use of EGIT_PROJECT as it is going to be deprecated and removed for future compatibility. Thanks.

Comment 1 Michał Górny archtester

2013-09-02 11:43:59 UTC

Folks, please don't change it right now. I will commit the new eclass in a few days and we can fix this while switching. This will save users from double re-download :).