Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482406 - dev-vcs/tig-1.2.1 version bump
Summary: dev-vcs/tig-1.2.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-25 10:48 UTC by Julian Ospald
Modified: 2013-08-29 10:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-08-25 10:48:59 UTC 
pre-generated docs are misplaced in the root folder since the asciidoc files are in the doc/ subfolder now, so build fails without xmlto

also: makefile sets version to "1.2.1.1" although the tarball is named "1.2.1". We could pass VERSION="${PV}" to emake


--- dev-vcs/tig/tig-1.2.ebuild
+++ dev-vcs/tig/tig-1.2.1.ebuild
@@ -16,6 +16,7 @@
 
 CDEPEND="sys-libs/ncurses"
 DEPEND="${CDEPEND}
+	app-text/xmlto
 	virtual/pkgconfig"
 RDEPEND="${CDEPEND}
 	dev-vcs/git"
Comment 1 Julian Ospald 2013-08-25 11:04:24 UTC 
a minor notice: makefile does not respect CFLAGS in the linking commands
Comment 2 Tim Harder gentoo-dev 2013-08-26 05:15:33 UTC 
(In reply to Julian Ospald (hasufell) from comment #1)
> a minor notice: makefile does not respect CFLAGS in the linking commands

CFLAGS shouldn't matter during linking anyway.

Added to CVS.
Comment 3 Julian Ospald 2013-08-26 10:45:22 UTC 
(In reply to Tim Harder from comment #2)
> (In reply to Julian Ospald (hasufell) from comment #1)
> > a minor notice: makefile does not respect CFLAGS in the linking commands
> 
> CFLAGS shouldn't matter during linking anyway.
> 

https://bugs.gentoo.org/show_bug.cgi?id=446281#c5
Comment 4 Tim Harder gentoo-dev 2013-08-26 17:35:40 UTC 
(In reply to Julian Ospald (hasufell) from comment #3)
> (In reply to Tim Harder from comment #2)
> > (In reply to Julian Ospald (hasufell) from comment #1)
> > > a minor notice: makefile does not respect CFLAGS in the linking commands
> > 
> > CFLAGS shouldn't matter during linking anyway.
> > 
> 
> https://bugs.gentoo.org/show_bug.cgi?id=446281#c5

Right, so again CFLAGS *shouldn't* matter during linking but people are sometimes oblivious. Anyway I'm planning to fix it but just didn't feel like doing it for the release since it's not highly important for a simple package like tig.
Comment 5 Julian Ospald 2013-08-26 17:44:59 UTC 
(In reply to Tim Harder from comment #4)
> (In reply to Julian Ospald (hasufell) from comment #3)
> > (In reply to Tim Harder from comment #2)
> > > (In reply to Julian Ospald (hasufell) from comment #1)
> > > > a minor notice: makefile does not respect CFLAGS in the linking commands
> > > 
> > > CFLAGS shouldn't matter during linking anyway.
> > > 
> > 
> > https://bugs.gentoo.org/show_bug.cgi?id=446281#c5
> 
> Right, so again CFLAGS *shouldn't* matter during linking but people are
> sometimes oblivious. Anyway I'm planning to fix it but just didn't feel like
> doing it for the release since it's not highly important for a simple
> package like tig.

I have sent this patch upstream


--- a/Makefile
+++ b/Makefile
@@ -184,7 +184,9 @@
 tig.o: tig.c tig.h io.h refs.h graph.h git.h
 
 tig: tig.o io.o graph.o refs.o $(COMPAT_OBJS)
-test-graph: io.o graph.o
+	$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(LDLIBS)
+test-graph: io.o graph.o test-graph.o
+	$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(LDLIBS)
 
 # To check the above.
 #